Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for RTCPeerConnectionCoordinator on handling negotiation/subscriberOffer #526

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Update tests for RTCPeerConnectionCoordinator on handling negotiation/subscriberOffer #526

merged 1 commit into from
Sep 18, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Sep 18, 2024 •
edited
Loading

📝 Summary

This revision adds the tests (and even more test cases) that were inside SFUMiddleware_Tests

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Sep 18, 2024
@ipavlidakis ipavlidakis added this to the Reconnection v2 milestone Sep 18, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 18, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 18, 2024 14:33
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.83 MB +438 KB 🟡
StreamVideoSwiftUI 2.18 MB 2.18 MB -2 KB 🚀
StreamVideoUIKit 2.32 MB 2.31 MB -2 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
107 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ipavlidakis ipavlidakis merged commit 8830dc2 into feature/reconnection-v2 Sep 18, 2024
13 checks passed
@ipavlidakis ipavlidakis deleted the reconnection-v2/reapply-robot-voice-filter-after-reconnection branch September 18, 2024 15:43
ipavlidakis added a commit that referenced this pull request Sep 19, 2024
@ipavlidakis
Update tests for RTCPeerConnectionCoordinator on handling negotiation…
e5d9c1a 
…/subscriberOffer (#526)
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
Update tests for RTCPeerConnectionCoordinator on handling negotiation…
584d7cf 
…/subscriberOffer (#526)
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
Update tests for RTCPeerConnectionCoordinator on handling negotiation…
cac90c5 
…/subscriberOffer (#526)
ipavlidakis added a commit that referenced this pull request Sep 26, 2024
@ipavlidakis
Update tests for RTCPeerConnectionCoordinator on handling negotiation…
0be2618 
…/subscriberOffer (#526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
Reconnection v2
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski