Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any dangers in using Prefetch on a Shopify website for optimization? #15652

Closed
remymedranda opened this issue Dec 1, 2023 · 2 comments
Assignees

Comments

@remymedranda
Copy link

I have a website client that is using Shopify, and recently was told that a prefetch code used on his site would lead their site being slower, the seo being negatively impacted, and hurting quality rankings on paid traffic channels. Also that the script was malicious. Can someone please help me look into these accusations for me because I don't believe one word of them. Our clients site has actually been doing really solid with performance so I just don't see this adding up.

400769447_1499087717554104_5080653991685773838_n
385557001_647332754236871_7173269589999077409_n (1)

Here's what's in our theme files:

{% unless template contains 'cart' %} {{ 'prefetch.js' | asset_url | script_tag }} {% endunless %}

Here's a link to the code
https://pastebin.com/wbcYi0BD

Is there anything malicious about this code that would harm the clients site?

@adamraine
Copy link
Member

This isn't an issue with Lighthouse. We are aware of these types of scams but can't help you analyze your own code for you in this case.

@adamraine adamraine closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2023
@remymedranda
Copy link
Author

remymedranda commented Dec 1, 2023

Can you elaborate on the scam part? For example, just the use of prefetch.js is a scam? This is what I would like to know more from and the perspective from Lighthouse on that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants