Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set cookie unsupport playwright,only support puppeter #16185

Closed
ljtyzx opened this issue Sep 12, 2024 · 2 comments
Closed

set cookie unsupport playwright,only support puppeter #16185

ljtyzx opened this issue Sep 12, 2024 · 2 comments
Assignees

Comments

@ljtyzx
Copy link

ljtyzx commented Sep 12, 2024

11.0.0

docs/recipes/auth/README.md
Feature request summary

i wan't set-cookie can be support by playwright
in docs/recipes/auth/README.md
i can only see that it support puppeter in the doc,when i use playwright, it throw a error:
/node_modules/lighthouse/core/gather/driver.js:82
const cdpSession = await this._page.target().createCDPSession();
^
TypeError: this._page.target is not a function

What is the motivation or use case for changing this?
first to be honest, in my department,suggest we use playwright to test our project
second the playwright project has 65.6 star,many project use it,it has many user

How is this beneficial to Lighthouse?
the playwright project has 65.6 star in GitHub,many project use it,it has many user,if it support, Lighthouse will have more user

@ljtyzx
Copy link
Author

ljtyzx commented Sep 12, 2024

image

this is my code and this is the error

/node_modules/lighthouse/core/gather/driver.js:82
const cdpSession = await this._page.target().createCDPSession();
^
TypeError: this._page.target is not a function

@adamraine
Copy link
Member

We don't officially support playwright, here is a previous discussion about it: #13326

@adamraine adamraine closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants