Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to load zipped version of event/geometry files in a generic way #441

Open
2 tasks
sponce opened this issue May 19, 2022 · 3 comments
Open
2 tasks
Labels
enhancement New feature or request

Comments

@sponce
Copy link
Collaborator

sponce commented May 19, 2022

- 'moved' and adapted from phoenix-helpers repo where it was created initially by mistake -

The gain in size is typically around a factor 10, so for a web based application, it would make sense to be able to use zipped versions of our data files, both for events and geometry. Now I had a look at the code, and the thressjs GLTFLoader does not seem to support it natively, so we would have to write it ourselves

answer from @9inpachi

We already do this but only in the event data import, not through the URL or anywhere else. The same logic could be extracted and reused though.

summary of discussion

This is for now Atlas specific and event specific. It should be available to all and also for geometry ideally

Steps remaining :

  • allow zip files for default event files
  • allow zipped geometries
@sponce
Copy link
Collaborator Author

sponce commented May 19, 2022

I've now added zip loading to LHCb events. It should probably be there by default for all cases though.
Remains 2 main point : allow zip for default event file and allow zip for geometry

@sponce sponce added the enhancement New feature or request label May 25, 2022
@EdwardMoyse
Copy link
Collaborator

Is this done?

@sponce
Copy link
Collaborator Author

sponce commented Dec 3, 2024

The zipped geometry is done indeed. I'm not sure what I meant for "default event file", but it's probably not done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants