Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aalib: fix implicit function declarations #892

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

samford
Copy link
Member

@samford samford commented Sep 22, 2023

Building aalib on macOS Sonoma produces a number of implicit function declaration errors (see Homebrew/homebrew-core#142161 (comment)). This modifies the existing patch to add more #include statements to resolve these errors.

I've created a draft homebrew/core PR that uses this (Homebrew/homebrew-core#144725) and I will modify that PR to use this updated patch once available.

Building `aalib` on macOS Sonoma produces a number of implicit
function declaration errors. This modifies the existing patch to add
more `#include` statements to resolve these errors.
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but can you give another shot at upstreaming this?

@samford
Copy link
Member Author

samford commented Sep 22, 2023

Approved, but can you give another shot at upstreaming this?

It may be worth mentioning that the most recent commit to the aa-project repository appears to be from 2002-11-26 (2001-05-03 for the aalib directory) and there are a number of open patch submissions from 2001 to 2017 that haven't been addressed: https://sourceforge.net/p/aa-project/patches/

That said, I can work on creating a patch submission when I have a free moment, if you want (I will need to create a SourceForge account). I'll have to look into the existing changes to understand those issues well enough to explain them, as this should probably be split into multiple patches when upstreaming. [From a cursory glance, there's already an open patch submission from 2005 for the aalib.m4 change.]

@samford samford merged commit 4cd6785 into Homebrew:master Sep 22, 2023
@samford samford deleted the sonoma/aalib-update-patch branch September 22, 2023 12:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants