Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing data in versioned cask pages #1149

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

EricFromCanada
Copy link
Member

As Liquid doesn't allow characters like @, ., or + in key names, we need to filter those out of cask token names as we did for formulae. More PRs are forthcoming, but this fixes the most obvious issue.

@EricFromCanada EricFromCanada merged commit 2b352ee into Homebrew:master Apr 30, 2024
1 check passed
@MikeMcQuaid
Copy link
Member

Thanks @EricFromCanada!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants