-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple possible Cask versions (e.g. per-OS) are not shown on formulae.brew.sh #965
Comments
Probably because site generation runs on macOS 12 still ( |
Yup. Addressed the title because I think the actual good fix for this is to use the |
So do we want to show the latest macOS version? Or all of the supported ones? |
@SMillerDev All supported. |
For anyone interested in tackling this: right now all of this info exists in the It might be worth looking into re-adding Edit: oops, now I see there's already a PR open for this |
@Rylan12 I think we need to have Homebrew/brew do the same as what we're doing for the website. I'm open to @Bo98 and @apainintheneck thoughts on how best to balance this as I agree including this information would be nice. |
Which APIs are we planning on adding cask variations to? I checked |
I'm not convinced anything more needs done here? Only remaining improvement to the webpages is I'd make is to fold "Current version" into the variations table as that version actually means "Version of the machine that generated this page (Monterey)". Example (note how Monterey is missing): https://formulae.brew.sh/cask/mysqlworkbench |
Could we get that info though? |
"Current version" applies to all missing variations, so the extra information we would need is the set of possible macOS versions. We could extract that from It would fill up the table on e.g. https://formulae.brew.sh/cask/amethyst a bit but it would behave consistently so would probably look ok (though that cask doesn't make sense anyway because of the >= 10.15, but that's an issue for homebrew-cask). |
In addition, we probably should also make it so API generation more system-agnostic. i.e. it simulates the latest x86_64 macOS so "current version" refers to macOS 14 even if generated on macOS 12. GitHub-hosted runners lagging over a year behind is probably not going to change anytime soon. |
Agreed 👍🏻 I think a happy middle ground could be a new field added to the API clarifying what the machine it was generated on is. |
Looking at https://formulae.brew.sh/cask/mysqlworkbench#default, this can be closed right? |
Yes, thanks @SMillerDev! |
There is a cask version mismatch between cask formula and formulae.brew.sh on the MySQL Workbench cask
formulae.brew.sh show as of UTC 9:40 pm 20th of september 2023 :
When copied and pasted
Current version: [8.0.32](https://cdn.mysql.com/Downloads/MySQLGUITools/mysql-workbench-community-8.0.32-macos-x86_64.dmg)
While cask code on the same time shows :
and
The text was updated successfully, but these errors were encountered: