Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run screenshot test in a separate github actions job #39

Open
joekrump opened this issue Jul 12, 2023 · 0 comments
Open

Run screenshot test in a separate github actions job #39

joekrump opened this issue Jul 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@joekrump
Copy link
Collaborator

  • Running screenshot tests on the same OS as the reference screenshots were run on can help ensure the screenshot comparisons are more similar. Ex. run screenshot tests on MacOS
  • Probably want to still run the rests of the RSpec test suite on an environment more similar to a production one (linux)

Splitting out the screenshot tests can allow this. It would also allow for independent scaling of the runner for the screenshot tests if those tests end up running slow compared with other RSpec tests.

The approach would involve having a new spec directory, something like spec/screenshot_specs that could then be ignored when the rest of the RSpec suite is run. This could be done using the --pattern cmd line arg

@joekrump joekrump added the enhancement New feature or request label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant