Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why we need __dataHasAccessor = {partial: true, viewModel: true #57

Open
tomalec opened this issue May 22, 2018 · 0 comments

Comments

@tomalec
Copy link
Member

tomalec commented May 22, 2018

see discussion at #56 (comment)

Steps to reproduce

  1. Go to https://github.com/Juicy/imported-template/blob/master/imported-template.html#L172

It hacks Polymer notification protocol to forward partial, viewModel even though we only use model. Removing them seems to breaks some tests #56 (comment)

Expected result

imported-template should care only about its own properties.

Actual result

It seems it may cover something on behalf of starcounter-include

//cc @alshakero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants