You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue is that ForwardDiff.jl only implements floatmax(T), while SpecialFunctions.jl uses floatmax(::T).
In Base, both are implemented, but only floatmax(T) is documented.
There are two possible straightforward solutions in this case (implementing floatmax(::T) in ForwardDiff, or adding a typeof in SpecialFunctions). Not sure if one of them should be preferred.
The text was updated successfully, but these errors were encountered:
I was surprised at first that this didn't hit the Base method for values that just dispatches to calling floatmax on the type, but I realized that the fallback is only for AbstractFloat. SpecialFunctions is surely not the only user of the method for values so it seems like adding such a method to ForwardDiff would be a better solution.
While trying to ForwardDiff
expint
, I got the following error:occurring at
SpecialFunctions.jl/src/expint.jl
Line 169 in c400278
The issue is that ForwardDiff.jl only implements
floatmax(T)
, while SpecialFunctions.jl usesfloatmax(::T)
.In Base, both are implemented, but only
floatmax(T)
is documented.There are two possible straightforward solutions in this case (implementing
floatmax(::T)
in ForwardDiff, or adding atypeof
in SpecialFunctions). Not sure if one of them should be preferred.The text was updated successfully, but these errors were encountered: