-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DelimitedFiles should now require compat entries #471
Comments
IIRC Registrator hasn't been in the business of compat bounds, but rather RegistryCI. Moreover, I would prefer checks like this to go to the latter bc RegistryCI itself has CI (unlike Registrator) and the version deployed to General is public/readable unlike Registrator (which can make debugging hard/confusing), and there's a broader set of folks who can deploy RegistryCI (General committers vs only @nkottary AFAIK). |
Yes, RegistratorCI is clearly where this should be opened. I moved it. |
Taking another look at this:
It looks like once 1.9 is out, General's AutoMerge workflow will switch to 1.9, and presumably those Pkg internals will no longer have DelimitedFiles as a stdlib, so we will start requiring compat then. Does that sound reasonable? Do we want to edit it so we rm DelimitedFiles from that list early so we start requiring it already? |
In JuliaRegistries/General#66039, compat for DelimtiedFiles was added so that when people start using 1.9 (where DelimitedFiles is not an stdlib) the resolver should not start picking old versions without DelimitedFiles compat.
We should probably require packages to declare compat with DelimitedFIles to avoid this issue coming back. It is not super urgent though since we can always add new compat entries but would be good to get done.
The rule is basically that before 1.9 you need to have the same compat for DelimitedFiles as you do for Julia. After 1.9 you can have whatever you want.
The text was updated successfully, but these errors were encountered: