You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a webpage's height is changed through settings or a query string, then drag-resized by the user, the frame snaps down to 400px height and can't be fixed without reloading the page. A bit of debugging narrows down the issue to https://github.com/Khan/live-editor/blob/master/js/live-editor.js#L1405. Since no height is passed to the updateCanvasSize function when it's resized by the user, it uses the default, which is 400.
I tested this with the console after the page loaded and it fixed it.
Edit:
Changing the objects default to whatever it started with when the editor is initialized would be better, since the editor's height is supposed to be able to be dragged, but the canvas's height is meant to be static.
The text was updated successfully, but these errors were encountered:
When a webpage's height is changed through settings or a query string, then drag-resized by the user, the frame snaps down to 400px height and can't be fixed without reloading the page. A bit of debugging narrows down the issue to https://github.com/Khan/live-editor/blob/master/js/live-editor.js#L1405. Since no height is passed to the updateCanvasSize function when it's resized by the user, it uses the default, which is 400.
could be changed to
I tested this with the console after the page loaded and it fixed it.
Edit:
Changing the objects default to whatever it started with when the editor is initialized would be better, since the editor's height is supposed to be able to be dragged, but the canvas's height is meant to be static.
The text was updated successfully, but these errors were encountered: