Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shading language support] Replace runtime GLSL shader compilation with offline compilation #1110

Open
SaschaWillems opened this issue Jul 20, 2024 · 0 comments
Labels
framework This is relevant to the framework hlsl Everything related to getting HLSL support added

Comments

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Jul 20, 2024

Ultimately after implementing #1107, #1108 and #1109 runtime GLSL shader compilations should be replaced with offline compilation in the same way we do with HLSL.

So instead of compiling shaders at runtime, GLSL shaders are compiled with CMake. We should also add the compilid SPIR-V files to the project (like we do with HLSL), so people wanting to try our samples can do so without the need of having a glsl compiler installed.

That way we can simplify some code and switching between GLSL and HLSL (or other shading languages to be added) would be no more than simply changing folders.

@SaschaWillems SaschaWillems added framework This is relevant to the framework hlsl Everything related to getting HLSL support added labels Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework This is relevant to the framework hlsl Everything related to getting HLSL support added
Projects
None yet
Development

No branches or pull requests

1 participant