Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dry-run validation to Loft and Shell #4711

Closed
pierremtb opened this issue Dec 9, 2024 · 1 comment · May be fixed by #4775
Closed

Add dry-run validation to Loft and Shell #4711

pierremtb opened this issue Dec 9, 2024 · 1 comment · May be fixed by #4775
Assignees
@pierremtb

Comments

@pierremtb
Copy link
Collaborator

pierremtb commented Dec 9, 2024 •
edited
Loading

Follow up from #4666, thread #4666 (comment)
@pierremtb pierremtb self-assigned this Dec 9, 2024
@pierremtb pierremtb mentioned this issue Dec 9, 2024
Merged
5 tasks
@pierremtb
Copy link
Collaborator Author

#4687 (comment)

pierremtb added a commit that referenced this issue Dec 11, 2024
@pierremtb
WIP: mess with shell selection validation
e4c5abe 
Will eventually fix #4711
@pierremtb pierremtb changed the title Improve shell selection guards for circular shapes Add selection validators to Loft and Shell Dec 13, 2024
@pierremtb pierremtb changed the title Add selection validators to Loft and Shell Add dry-run validators to Loft and Shell Dec 13, 2024
@pierremtb pierremtb changed the title Add dry-run validators to Loft and Shell Add dry-run validation to Loft and Shell Dec 13, 2024
@pierremtb pierremtb mentioned this issue Dec 13, 2024
Draft
pierremtb added a commit that referenced this issue Dec 16, 2024
@pierremtb
Add dry-run validation to Loft
79bcace 
Checks one box for #4711
@pierremtb pierremtb mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierremtb pierremtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dry-run validation to Shell KittyCAD/modeling-app
1 participant
@pierremtb