Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add options discardSocketError and discardSocketErrorThreshold #186

Open
evroom opened this issue Dec 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@evroom
Copy link

evroom commented Dec 17, 2024

As a follow-up to the "Intermittent errors: Loading - undefined" issue, I would like to propose some additional options and counter(s).

Counter: socketErrorCount:
Count the sequential occurrences of socket errors.
Reset to 0 when a successful fetching of data was done.

Option: discardSocketError: true | false
Should a socket error occur, allow for the module to discard it.
As a result the information on the display will still show, iso the error message (true).
Or it will always show the socket error (false).

Option: discardSocketErrorThreshold: 1 .. 9
Discard the socket error from being displayed until a threshold has been crossed.
Discard socket error when discardSocketError = true and socketErrorCount <= discardSocketErrorThreshold
Display socket error when discardSocketError = true or socketErrorCount > discardSocketErrorThreshold

In addition , you have this option "displayLastUpdate: true" and with that you can potentially play a bit.

"Last update: Mon 16 Dec 10:35:37 CET 2024" (show when last request was okay - socketErrorCount = 0)
"Last update (socket issues: 2): Mon 16 Dec 10:35:37 CET 2024" (show when socketErrorCount > 0)

@evroom evroom added the enhancement New feature or request label Dec 17, 2024
@evroom
Copy link
Author

evroom commented Dec 17, 2024

I can be that the option discardSocketError is not really necessary.

discardSocketErrorThreshold: 0 is equal to false
discardSocketErrorThreshold: > 0 is equal to true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant