Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When viewing PDF, show a "digitally signed" icon on the top bar #4163

Open
Extarys opened this issue Dec 18, 2024 · 2 comments
Open

When viewing PDF, show a "digitally signed" icon on the top bar #4163

Extarys opened this issue Dec 18, 2024 · 2 comments
Labels
feature-request New feature request

Comments

@Extarys
Copy link

Extarys commented Dec 18, 2024

Is your feature request related to a problem? Please describe.
When viewing PDFs, it might be hard to see that it was digitally signed.

Describe the solution you'd like

Create/add a "universal" icon next to the three dots on the top navbar when the opened PDF has any digital signature, instead

image

Hovering would show a "This file contains digital signatures, click for more details."
On click, the sidebar could open and show the same details as it would on the "LibreSign" tab when we select the file in Files. See #4164

to avoid people who feel like this would create clutter, add an admin option to show/hide this by default.

Describe alternatives you've considered

Additional context
I saw an issue about the nextcloud pdf viewer, not sure what happened with that, but I cannot open the sidebar from those three dots. 🤷

@Extarys Extarys added the feature-request New feature request label Dec 18, 2024
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Dec 18, 2024
@vitormattos
Copy link
Member

Good idea!

Did you have a visual suggestion about the icon? Like a moockup.

About the way to open signature details this suggestion could affect the follow issue:

I liked the idea to open at right side, a point to think is how this will work at mobile devices.

@Extarys
Copy link
Author

Extarys commented Dec 18, 2024

Did you have a visual suggestion about the icon? Like a moockup.

Either the LibreSign logo, or if this is shown for all signed pdf, even the ones not signed by LibreSign, a more generic icon like your signature but in color neutral (white) to fit the other icons :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
Status: 0. Needs triage
Development

No branches or pull requests

2 participants