From 989b6b571b7bf2f93595a2a23e60b33585db2e3a Mon Sep 17 00:00:00 2001 From: Vitor Mattos Date: Thu, 19 Dec 2024 14:48:29 -0300 Subject: [PATCH 1/2] chore: implement logs Signed-off-by: Vitor Mattos --- lib/Service/Install/ConfigureCheckService.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/Service/Install/ConfigureCheckService.php b/lib/Service/Install/ConfigureCheckService.php index 2d7385fbb1..e4cb9f2911 100644 --- a/lib/Service/Install/ConfigureCheckService.php +++ b/lib/Service/Install/ConfigureCheckService.php @@ -14,6 +14,7 @@ use OCA\Libresign\Handler\JSignPdfHandler; use OCA\Libresign\Helper\ConfigureCheckHelper; use OCP\AppFramework\Services\IAppConfig; +use Psr\Log\LoggerInterface; class ConfigureCheckService { private string $architecture; @@ -25,6 +26,7 @@ public function __construct( private JSignPdfHandler $jSignPdfHandler, private CertificateEngine $certificateEngine, private SignSetupService $signSetupService, + private LoggerInterface $logger, ) { $this->architecture = php_uname('m'); } @@ -243,6 +245,7 @@ private function getErrorAndTipToResultOfVerify(array $result): array { ]; } } + $this->logger->error('Invalid hash of binaries files', ['result' => $result]); return [ 'Invalid hash of binaries files.', 'Run occ libresign:install --all', From 3ea292c49ae21232c3f7666fc70bcd4a247464c8 Mon Sep 17 00:00:00 2001 From: Vitor Mattos Date: Thu, 19 Dec 2024 14:53:47 -0300 Subject: [PATCH 2/2] chore: add pcntl to solve psalm issue Fixed: pcntl_fork() is disabled by php configuration (disable_functions directive). Signed-off-by: Vitor Mattos --- .github/workflows/psalm.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/psalm.yml b/.github/workflows/psalm.yml index e9258903b7..8be471cbe3 100644 --- a/.github/workflows/psalm.yml +++ b/.github/workflows/psalm.yml @@ -31,7 +31,8 @@ jobs: uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1 with: php-version: ${{ steps.versions.outputs.php-available }} - extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite + extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, pdo_sqlite, posix, session, simplexml, sqlite, xmlreader, xmlwriter, zip, zlib + ini-values: disable_functions="" coverage: none ini-file: development env: