From 9fb58c7876e02745a8d19c2f200d6a78469e32bc Mon Sep 17 00:00:00 2001 From: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com> Date: Thu, 19 Sep 2024 10:28:11 -0400 Subject: [PATCH] feat!: remove discussion announcment (#188) --- .github/workflows/ci.yml | 8 ++------ README.md | 1 - action.yml | 5 ----- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a684330..60d7f38 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,23 +28,20 @@ jobs: id: setup-release uses: LizardByte/setup-release-action@master # keep this on master, to prevent endless depandabot PRs with: - fail_on_events_api_error: # PRs will fail if this is true - ${{ github.event_name == 'pull_request' && 'false' || 'true' }} + # PRs will fail if this is true + fail_on_events_api_error: ${{ github.event_name == 'pull_request' && 'false' || 'true' }} github_token: ${{ secrets.GITHUB_TOKEN }} # can use GITHUB_TOKEN for read-only access - name: Set action variables id: vars run: | if [ "${{ github.event_name }}" == "pull_request" ]; then - discussion_category=tests release_tag=pr-${{ github.event.pull_request.number }}-${{ github.run_id }} else - discussion_category=announcements release_tag=${{ steps.setup-release.outputs.release_tag }} fi # set outputs - echo "discussion_category=$discussion_category" >> $GITHUB_OUTPUT echo "release_tag=$release_tag" >> $GITHUB_OUTPUT - name: Run Action @@ -54,7 +51,6 @@ jobs: allowUpdates: false artifacts: '' body: ${{ steps.setup-release.outputs.release_body }} - discussionCategory: ${{ steps.vars.outputs.discussion_category }} generateReleaseNotes: ${{ steps.setup-release.outputs.release_generate_release_notes }} name: ${{ steps.vars.outputs.release_tag }} prerelease: true diff --git a/README.md b/README.md index b825eb0..b5eb365 100644 --- a/README.md +++ b/README.md @@ -32,7 +32,6 @@ steps: | body | The body of the release. | | `false` | | deleteOtherPreReleases | Whether to delete other pre-releases. | `true` | `false` | | deletePreReleaseTags | Whether to delete other pre-release tags. | `true` | `false` | -| discussionCategory | The category for the discussion. | `announcements` | `false` | | generateReleaseNotes | Indicates if release notes should be automatically generated. | `true` | `false` | | keepPreReleaseCount | The number of pre-releases to keep. | `2` | `false` | | name | The version to create. | | `true` | diff --git a/action.yml b/action.yml index 954fa59..bc304ea 100644 --- a/action.yml +++ b/action.yml @@ -27,10 +27,6 @@ inputs: description: 'Whether to delete other pre-releases tags.' required: false default: 'true' - discussionCategory: - description: 'The category of the discussion.' - required: false - default: 'announcements' generateReleaseNotes: description: 'Indicates if release notes should be automatically generated.' required: false @@ -71,7 +67,6 @@ runs: artifacts: ${{ inputs.artifacts }} body: ${{ inputs.body }} commit: ${{ github.sha }} - discussionCategory: ${{ inputs.discussionCategory }} generateReleaseNotes: ${{ inputs.generateReleaseNotes }} name: ${{ inputs.name }} prerelease: ${{ inputs.prerelease }}