Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx.log显示的hint不对 #1189

Closed
mingkwind opened this issue Jun 2, 2022 · 4 comments
Closed

ngx.log显示的hint不对 #1189

mingkwind opened this issue Jun 2, 2022 · 4 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request feat/LuaCats Annotations Related to Lua Language Server Annotations (LuaCats)

Comments

@mingkwind
Copy link

image

image

这个不应该加引号的,ngx.ERR是number
@CppCXY
Copy link
Collaborator

CppCXY commented Jun 2, 2022

我初始贡献openresty api文档之后很多人对该文档有pr,但是pr的质量我管不了。
这里ngx.log是因为他们希望这里应该是枚举但是当时sumneko lua并没有这样的支持,但是在pr中他们依然把ngx.log文档修改为一个近似的表达。
在这里你可以通过pr修改下文档。有没有什么方式支持这种枚举去问作者吧。

@flrgh
Copy link
Contributor

flrgh commented Jun 3, 2022

Right, so the annotations I created for the log level constants used to work (I think), but they don't anymore:

#1061
#1116

According to the primary developer, it will be possible to annotate these constants properly using backticks, though I'm not sure when this feature is planned to be worked on/released.

@C3pa
Copy link
Contributor

C3pa commented Jun 3, 2022

Yes, #1061 is currently a blocker issue.

@sumneko sumneko added enhancement New feature or request feat/LuaCats Annotations Related to Lua Language Server Annotations (LuaCats) duplicate This issue or pull request already exists labels Jun 4, 2022
@sumneko
Copy link
Collaborator

sumneko commented Jun 9, 2022

Discuss in #1061

@sumneko sumneko closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request feat/LuaCats Annotations Related to Lua Language Server Annotations (LuaCats)
Projects
None yet
Development

No branches or pull requests

5 participants