Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Version 2.0.0 #106

Open
Ogremair opened this issue Sep 25, 2024 · 40 comments
Open

Update for Version 2.0.0 #106

Ogremair opened this issue Sep 25, 2024 · 40 comments

Comments

@Ogremair
Copy link

Game has new update which broke MGSHDFix

@Zonrotan
Copy link

I can confirm. HDFix is completely borked regardless of "Resolution setting" set in the new menu.

@Lyall
Copy link
Owner

Lyall commented Sep 25, 2024

I should be able to have a proper look this weekend. It looks like based on quickly looking at the log results that it's mostly resolution and window management stuff that's broken by the update.

@MasterDarkseid
Copy link

I should be able to have a proper look this weekend. It looks like based on quickly looking at the log results that it's mostly resolution and window management stuff that's broken by the update.

I don't know how to modify it myself but yes. It's only resolution and window management. The update also made the windowed mode option bugged (it resets everytime you reset the games)

@mben67
Copy link

mben67 commented Sep 25, 2024

also if you can add the option in the ini file to change the mouse sensitivity for mgs2 like mgs3 that would be awesome! thanks by your hard work!!

@ShizCalev
Copy link
Contributor

ShizCalev commented Sep 25, 2024

@emoose @Lyall Just to note for the update, it appears Konami has added 32MB intro logo textures to both MGS2 & MGS3, which surpasses the old 16MB texture buffer size limit that was previously expanded for MGS3 w/ MGSHDFix via #39
image

I'd assume that might mean that they've backported the TextureBufferMalloc stuff which previously prevented #39 from being implemented in MGS2 (and likely upped the vanilla limit from what it was before.)

@brad86m
Copy link

brad86m commented Sep 28, 2024

Patiently waiting and looking forward to your update. Do you think it would also be possible to also make the new internal resolution feature actually work past the monitor's max resolution ? They've basically just natively implemented a feature that your mod had the entire time. I'd love to push some crazy 8K IR to clean up all aliasing left in the game, and have it downsample to my 1080p monitor. I'd normally force SGSSAA via Profile Inspector on old games, but sadly it doesn't work with DX11

@Lyall
Copy link
Owner

Lyall commented Sep 28, 2024

@emoose @Lyall Just to note for the update, it appears Konami has added 32MB intro logo textures to both MGS2 & MGS3, which surpasses the old 16MB texture buffer size limit that was previously expanded for MGS3 w/ MGSHDFix via #39 image

I'd assume that might mean that they've backported the TextureBufferMalloc stuff which previously prevented #39 from being implemented in MGS2 (and likely upped the vanilla limit from what it was before.)

Looks like they updated the 9 calls to malloc from 16MB to 128MB limits.

METAL GEAR SOLID3.exe+66B33 - B9 00000008           - mov ecx,08000000 { 134217728 }
METAL GEAR SOLID3.exe+66B38 - FF 15 E22D8300        - call qword ptr ["METAL GEAR SOLID3.exe"+899920] { ->ucrtbase.malloc }
METAL GEAR SOLID3.exe+66B3E - 48 8B F8              - mov rdi,rax

Is it still worth offering a customizable size @ShizCalev?

Patiently waiting and looking forward to your update. Do you think it would also be possible to also make the new internal resolution feature actually work past the monitor's max resolution ? They've basically just natively implemented a feature that your mod had the entire time. I'd love to push some crazy 8K IR to clean up all aliasing left in the game, and have it downsample to my 1080p monitor. I'd normally force SGSSAA via Profile Inspector on old games, but sadly it doesn't work with DX11

Yes, I've just added that as a new feature in the update. You can run the game at an arbitrary internal resolution now.

@Lyall
Copy link
Owner

Lyall commented Sep 28, 2024

Since this update is so big I've put up a version for people to test first before removing the pre-release tag.
https://github.com/Lyall/MGSHDFix/releases/tag/v2.3

If you try this, please let me know if it works okay for you. If you run in to any issues, remember to post your MGSHDFix.log file here and I can see what went wrong.

@JohnHargis
Copy link

JohnHargis commented Sep 28, 2024

Game doesn't seem to start without the skiplauncher option set to true, but other than that seems to work at the moment
MGSHDFix.log
heres a log with it set to false

@Lyall
Copy link
Owner

Lyall commented Sep 28, 2024

Game doesn't seem to start without the skiplauncher option set to true, but other than that seems to work at the moment

Is this with MGS2 or MGS3? Also you copied over all files from the v2.3 zip right? It now comes with 2 ASI loader DLLs, one for the launcher and one for the games.

@JohnHargis
Copy link

JohnHargis commented Sep 28, 2024

MGS2, sorry, and yes all files copied over. even the readme cause im lazy

@Lyall
Copy link
Owner

Lyall commented Sep 28, 2024

MGS2, sorry, and yes all files copied over. even the readme cause im lazy

Have you removed d3d11.dll from the game folder, if you had an old version of the fix installed?

@JohnHargis
Copy link

I did not do that, thought i did. Alright well that seems to fix that issue

@Lyall
Copy link
Owner

Lyall commented Sep 29, 2024

I did not do that, thought i did. Alright well that seems to fix that issue

I'll add a note about that to the release notes for v2.3. No doubt it'll catch more people out!

@Dio141
Copy link

Dio141 commented Sep 29, 2024

MGS3 works like a charm with the new patch, and choosing higher internal resolutions work without a hitch(tried 8k).
With MGS2 tho, its as if the game isnt downscaling/outputting to the correct output res, so you cant see everything. an example(this should be outputting to 1440p, with an internal res of 4k):
METAL_GEAR_SOLID2_2024-09-28_21-06-19
MGSHDFix.log

@Lyall
Copy link
Owner

Lyall commented Sep 29, 2024

MGS3 works like a charm with the new patch, and choosing higher internal resolutions work without a hitch(tried 8k). With MGS2 tho, its as if the game isnt downscaling/outputting to the correct output res, so you cant see everything. an example(this should be outputting to 1440p, with an internal res of 4k): METAL_GEAR_SOLID2_2024-09-28_21-06-19 MGSHDFix.log

Just to confirm I am seeing that on my end. I'll look into it. Thanks everyone for the feedback so far!

@LethalPlacebo
Copy link

LethalPlacebo commented Sep 29, 2024

Just tried out the new patch, made sure to delete d3d11.dll before copying over the new files. Just about everything works correctly for me, playing at native 1440p, thank you! Here are some notes:

-For MG1/MG2 and MGS3, when choosing "End game" in MG1 or MG2 or "Return to Main Menu" in MGS3, the game will just close and the launcher will not re-open, even if "skip launcher" is set to false. This is not the case in MGS2, where the launcher will come back up. Edit: nevermind, this seems somewhat random as to whether or not the launcher will come back up.
-Make sure in the launcher options to set all the resolution options to DEFAULT. Otherwise, it can interfere with what MGSHDFix is trying to do and result in a very strange looking output, it will almost appear as though the image is interlaced. After doing that, MGSHDFix worked perfectly.

@OddOttAllen
Copy link

konami logo (and etc) skip doesn't seem to work, that's the only issue i've had so far though

@LethalPlacebo
Copy link

konami logo (and etc) skip doesn't seem to work, that's the only issue i've had so far though

This is working for me on MGS2 and MGS3. It's not supposed to work for MG1/MG2.

@LunaRosalie
Copy link

Make sure to write down people have to have everything set to default because using the upscalers with each other, Interlaces images like crazy.
anyway i will say visual quality between my adjusted mode 1440p vs this is very uhh. well Top is Konami Bottom is mod.
https://imgur.com/a/lMqJY0c I dunno Maybe it looks better on a 4K monitor.
Weirdly i think their adjusted looks better cause its slightly sharper, Will be using the mod for borderless window'd anyway

@LethalPlacebo
Copy link

Make sure to write down people have to have everything set to default because using the upscalers with each other, Interlaces images like crazy. anyway i will say visual quality between my adjusted mode 1440p vs this is very uhh. well Top is Konami Bottom is mod. https://imgur.com/a/lMqJY0c I dunno Maybe it looks better on a 4K monitor. Weirdly i think their adjusted looks better cause its slightly sharper, Will be using the mod for borderless window'd anyway

I think image quality appears higher on the Konami version because they implemented FSR, which takes effect when you change the upscaling method from "Original" to "Adjusted" in the launcher. On the other hand, the top image appears more aliased, maybe turning on the adjusted upscaling method disables the built-in MSAA in the game?

@OddOttAllen
Copy link

konami logo (and etc) skip doesn't seem to work, that's the only issue i've had so far though

This is working for me on MGS2 and MGS3. It's not supposed to work for MG1/MG2.

apologies for not saying what games i was testing, but it was indeed MGS2/3, i don't have MG1/2 installed

@ShizCalev
Copy link
Contributor

ShizCalev commented Sep 29, 2024

I think image quality appears higher on the Konami version because they implemented FSR, which takes effect when you change the upscaling method from "Original" to "Adjusted" in the launcher. On the other hand, the top image appears more aliased, maybe turning on the adjusted upscaling method disables the built-in MSAA in the game?

It's the illusion of appear higher quality due to the upscaler messing with texture rendering sizes. A couple texture modders (myself included) have noted that enabling FSR causes mipmaps to act as if the screen is rendering at a higher resolution, making textures appear "sharper", to the point of EXTREME overshapening (especially when using high res mods.)

These shots are WITHOUT MGSHDFix
1080p with no FSR:
image

1080p WITH 4k upscaling/FSR enabled
image

@LethalPlacebo
Copy link

I think image quality appears higher on the Konami version because they implemented FSR, which takes effect when you change the upscaling method from "Original" to "Adjusted" in the launcher. On the other hand, the top image appears more aliased, maybe turning on the adjusted upscaling method disables the built-in MSAA in the game?

It's not really higher image quality, a couple texture modders (myself included) have noted that enabling FSR causes mipmaps to act as if the screen is rendering at a higher resolution, making textures appear "sharper", to the point of EXTREME overshapening when using high res mods.

That explains a lot, thank you. The oversharpening does look really bad. That explains the "aliasing" I was seeing, just noise introduced from sharpening.

@LunaRosalie
Copy link

That explains why its sharper, Yeah i prefer the oversharpen effect, TAA, DLSS and Depth of field, and motion blur and Anything designed to blur the screen is the bane of my existence I want to play video games not simulate damaged eye sight. like i would 100% rather play the bottom image there.

@Jamezlap
Copy link

I just tried the new update and it fixed the ultrawide issue so thank you! What I noticed is that the quality looks really bad when i set it up to 5120x1440 when last time it used to look better

@LethalPlacebo
Copy link

I just tried the new update and it fixed the ultrawide issue so thank you! What I noticed is that the quality looks really bad when i set it up to 5120x1440 when last time it used to look better

Make sure you go into the game's launcher settings and set all resolution options to Default/Original.

@ShizCalev
Copy link
Contributor

ShizCalev commented Sep 29, 2024

A bit of a feature request for the new version, would it be possible to have the correct splashscreens & loading screens load in based off your MGSHDFix resolution?

Ie, in 2.0.0 konami made it so that 4k versions of the loading & splashscreens are loaded in when your upscaler is set to 4k, 1440p versions of them all when set to WQHD, 1080p ones when set to original, 720p when internal resolution is set to original, ect

Right now the lower quality 1920x1080 versions are loading in when the game's set to Internal Resolution FHD, Upscaler Original, & MGSHDFix set to 3840x2160 (4k)

2024-09-29_00-23-24-METAL_GEAR_SOLID2-METAL_GEAR_SOLID_2_SONS_OF_LIBERTY
2131640_20240929002306_1

Here's all the loading screens & the konami splashscreens modified with their resolution written on them to make it easier to test. ♥
Misc.zip

I'd suggest having it based off vertical resolution, ie;

if(Height >= 2160)
	icons = 4k
else if(Height >= 1440)
	icons = WQHD
else if(Height >= 1080)
	icons = FHD
else
	icons = 720

@Jamezlap
Copy link

I just tried the new update and it fixed the ultrawide issue so thank you! What I noticed is that the quality looks really bad when i set it up to 5120x1440 when last time it used to look better

Make sure you go into the game's launcher settings and set all resolution options to Default/Original.

Yes! This definitely works thank you!

@brugalman
Copy link

Deleted d3d11.dll from my game files before installing MGSHDFix v2.3 and now the game is actually rendering at native 1440p and borderless windowed works again! Thank you so much Lyall! <3

@Wronschien
Copy link

Hello, using test version 2.3 (never tried any previous one) the launcher doesn't seem to honour any of the settings of the 'MGSHDFix.ini' file, like skip intro or windowed mode. Options seem correctly applied in-game though.
I tried MG1/MG2, MGS2 and MGS3 and it's the same.

@githbubble
Copy link

Deleted d3d11.dll from my game files before installing MGSHDFix v2.3 and now the game is actually rendering at native 1440p and borderless windowed works again! Thank you so much Lyall! <3

Same ! thanks! i had a black stripe on the right of my screen and thanks to the 2.3 no more problem.

@YabbaDabbaDont
Copy link

MGS2 works fine for me, but MGS3 isn't working with the DPI scaling on my machine. I have scaling set to 200% and MGS3 renders at double the size and cuts off most of image. If I switch my DPI scaling back to 100%, it shows up fine. Using default settings from a fresh install of the game and the mod.

@Dio141
Copy link

Dio141 commented Oct 9, 2024

MGS2 works fine for me, but MGS3 isn't working with the DPI scaling on my machine. I have scaling set to 200% and MGS3 renders at double the size and cuts off most of image. If I switch my DPI scaling back to 100%, it shows up fine. Using default settings from a fresh install of the game and the mod.

ohhh, this explains why using 125% scaling on my 1440p monitor is cutting some of the image. ill make the game be the one to set the scaling and see if it still getting cut.

EDIT: nope, MGS2 is still not rendering everything if the res is bigger than the native res regardless.

@ShizCalev
Copy link
Contributor

ShizCalev commented Oct 10, 2024

MGS2 works fine for me, but MGS3 isn't working with the DPI scaling on my machine. I have scaling set to 200% and MGS3 renders at double the size and cuts off most of image. If I switch my DPI scaling back to 100%, it shows up fine. Using default settings from a fresh install of the game and the mod.

That's an extremely common issue with many games (I know it alllll too well and frequently have to fix it too haha.)

To fix it:

Open regedit and go to
Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AppCompatFlags\Layers
Add a new string w/ the name of the full path of METAL GEAR SOLID3.exe, and add HIGHDPIAWARE as the value. (This tells Windows to outright ignore all DPI scaling for the program.)
image

image

@Wronschien
Copy link

Is there a way to force window centering ?

I have a 1200p screen but I want to play in 1080p, because it's wider.
So I set output to 1200p and internal to 1080p. It works but the display zone remains to the top of the screen rather than being vertically centered.
As a test I also tried a 1.33 aspect ratio and this time the window is neither centered vertically nor horizontally, but sticks to the top-left corner.

@ShizCalev
Copy link
Contributor

Is there a way to force window centering ?

https://github.com/Codeusa/Borderless-Gaming
you can do that with borderless gaming :>

@Wronschien
Copy link

Thanks for the suggestion, but to use it I should set the output to 1080p in the .ini, so the remaining 120 pixels will display the desktop, whereas using an output of 1200p fills in with black. That's why I'd prefer a centering method within MGSHDFix.
Besides it's a paid app on steam now, and I don't think I'll have enough usage of it to justify the purchase.

@ShizCalev
Copy link
Contributor

ShizCalev commented Oct 12, 2024

Besides it's a paid app on steam now, and I don't think I'll have enough usage of it to justify the purchase.

https://github.com/Codeusa/Borderless-Gaming/releases/tag/9.5.6

It's still available to download for free right here, actually. The steam version is just if you want to support the dev's work.

@Wronschien
Copy link

Well I tried it and it doesn't work as I was hoping for : the window is stretched out to fit the screen instead of being centered.

So I searched around and found this one : https://westechsolutions.net/sites/WindowedBorderlessGaming/
This time centering works but as expected the top and bottom parts display the desktop, so not ideal.

Well, as long as MGSHDFix doesn't forcibly center the internal window within the output, this will have to do. And I still can have a black image behind the game if that's really annoying.

Thank you for taking the time to help me (and indirectly pointing me to a viable solution !).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests