Attempting to invoke Lychee context menu Download function on a single image results in incorrect API request type

[jessienab]

Lychee version

v6.0.1

Which PHP version are you using?

PHP 8.2

Detailed description of the problem

This bug is regarding use of the "Download" function, found in the Lychee context menu:

The Download function is available to logged in users with permission to albums, or to public anonymous users IF the root album has "Downloadable" enabled.

If an attempt is made to use the context menu to download a single album's photo, the Zip function is invoked on the ID of the photo. However, it appears that the photo ID is being passed as an album, instead of as a photo ID.

Ex.

• Go to: https://photos . nabein . me/gallery/joseX_QxkSFa-KTE4DtLy5aC

• Right click an image

• Select Download

• API call made is: api/v2/Zip?album_ids=q5MYBmAuLNJ61S5X_Qgqs9Ae

• Proper API call should be: api/v2/Zip?photo_ids=q5MYBmAuLNJ61S5X_Qgqs9Ae&variant=$variant
  (where $variant reflects selected option)

Error generated with present API call to album_ids:

Error	2024-11-04 21:23:16	production	
App\Factories\AlbumFactory::findBaseAlbumsOrFail:184 No query results for model [App\Models\BaseAlbumImpl] q5MYBmAuLNJ61S5X_Qgqs9Ae	

Full error output:

Not Found
Symfony\Component\HttpKernel\Exception\NotFoundHttpException
No query results for model [App\Models\BaseAlbumImpl] q5MYBmAuLNJ61S5X_Qgqs9Ae
GET photos.nabein.me
PHP 8.2.24 — Laravel 11.29.0
4 vendor frames collapsed
4 vendor frames collapsed
33 vendor frames collapsed
4 vendor frames collapsed
vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php :634

vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php :582

vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php :51

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :146

app/Http/Middleware/AcceptContentType.php :74

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php :51

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php :88

app/Http/Middleware/VerifyCsrfToken.php :44

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Session/Middleware/AuthenticateSession.php :67

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php :49

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php :121

vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php :64

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php :37

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php :75

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :119

vendor/laravel/framework/src/Illuminate/Routing/Router.php :807

vendor/laravel/framework/src/Illuminate/Routing/Router.php :786

vendor/laravel/framework/src/Illuminate/Routing/Router.php :750

vendor/laravel/framework/src/Illuminate/Routing/Router.php :739

vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php :201

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :144

vendor/bepsvpt/secure-headers/src/SecureHeadersMiddleware.php :18

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php :21

vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php :31

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php :21

vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php :51

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Http/Middleware/ValidatePostSize.php :27

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php :110

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php :58

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

app/Http/Middleware/FixStatusCode.php :30

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :183

vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php :119

vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php :176

vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php :145

public/index.php :73

Request
GET /api/v2/Zip
Headers

cookie


sec-fetch-user

?1

sec-fetch-site

same-origin

sec-fetch-mode

navigate

sec-fetch-dest

document

upgrade-insecure-requests

1

accept-encoding

gzip, deflate, br

accept-language

en-US,en;q=0.5

accept

text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/jxl,image/webp,*/*;q=0.8

user-agent

Mozilla/5.0 (X11; Linux x86_64; rv:115.0) Gecko/20100101 Firefox/115.16.1

x-real-ip


x-forwarded-proto

https

x-forwarded-for


connection

upgrade

scheme

https

host

photos.nabein.me

Body

{
    "/api/v2/Zip": null,
    "album_ids": "q5MYBmAuLNJ61S5X_Qgqs9Ae"
}

Application
Routing

controller

App\Http\Controllers\Gallery\AlbumController@getArchive

route name

download

middleware

api, accept_content_type:any

Database Queries

mysql (1.86 ms)

select `key`, `value` from `configs`

mysql (0.36 ms)

select * from `users` where `id` = 1 limit 1

mysql (0.33 ms)

select * from `configs` where `key` = 'email' limit 1

mysql (0.26 ms)

select * from `configs` where `key` = 'license_key' limit 1

mysql (0.31 ms)

select `tag_albums`.*, null as max_taken_at, null as min_taken_at from `tag_albums` where `tag_albums`.`id` in ('q5MYBmAuLNJ61S5X_Qgqs9Ae')

mysql (0.44 ms)

select `albums`.*, (select MIN(taken_at) from `albums` as `a` inner join `photos` on `album_id` = `a`.`id` where `a`.`_lft` >= `albums`.`_lft` and `a`.`_rgt` <= `albums`.`_rgt` and `taken_at` is not null) as `min_taken_at`, (select MAX(taken_at) from `albums` as `a` inner join `photos` on `album_id` = `a`.`id` where `a`.`_lft` >= `albums`.`_lft` and `a`.`_rgt` <= `albums`.`_rgt` and `taken_at` is not null) as `max_taken_at`, (select COUNT(*) from `albums` as `a` where `a`.`parent_id` = `albums`.`id`) as `num_children`, (select COUNT(*) from `photos` as `p` where `p`.`album_id` = `albums`.`id`) as `num_photos` from `albums` where `albums`.`id` in ('q5MYBmAuLNJ61S5X_Qgqs9Ae')

Steps to reproduce the issue

1. Go to: https://photos . nabein . me/gallery/joseX_QxkSFa-KTE4DtLy5aC

2. Right click an image

3. Select Download

4. API call made is: api/v2/Zip?album_ids=q5MYBmAuLNJ61S5X_Qgqs9Ae

5. Proper API call should be: api/v2/Zip?photo_ids=q5MYBmAuLNJ61S5X_Qgqs9Ae&variant=$variant
   (where $variant reflects selected option)

Diagnostics [REQUIRED]

Errors
warning
lossless_optimization set to 1 but svgo not found!
warning
zend.assertions is disabled although Lychee is in debug mode. For easier debugging code generation for assertions should be enabled.
info
Latest version of PHP is 8.3
warning
Online updates are disabled by configuration
info
Found 8 medium that could be generated.
info
Have you considered supporting Lychee? :)
Info

Lychee Version (tag):                      v6.0.1 (6fc3e35) -- Up to date (-5.0862506341958E-11 years ago).
DB Version:                                6.0.1
composer install:                          --no-dev
APP_ENV:                                   production
APP_DEBUG:                                 true
APP_URL:                                   set
APP_DIR:                                   default
LOG_VIEWER_ENABLED:                        true
VUEJS_ENABLED:                             true
PHOTO_PIPES:                               true
System:                                    Linux
PHP Version:                               8.2.24
PHP User agent:                            Lychee/4 (https://lycheeorg.github.io/)
Timezone:                                  America/Toronto
Max uploaded file size:                    100M
Max post size:                             100M
Chunk size:                                25.60 MB
Max execution time:                        3600
MySQL Version:                             10.11.9-MariaDB-ubu2204
exec() Available:                          yes
Imagick Available:                         1
Imagick Enabled:                           1
Imagick Version:                           1691
GD Version:                                2.3.3
Number of foreign key:                     12 found.

		

Space

Lychee total space:                        208.52 MB
		

Configuration

version:                                   060001
check_for_updates:                         0
sorting_photos_col:                        taken_at
sorting_photos_order:                      ASC
sorting_albums_col:                        title
sorting_albums_order:                      ASC
imagick:                                   1
skip_duplicates:                           0
small_max_width:                           0
small_max_height:                          360
medium_max_width:                          1920
medium_max_height:                         1080
lang:                                      en
image_overlay_type:                        desc
default_license:                           CC0
compression_quality:                       90
grants_full_photo_access:                  1
delete_imported:                           0
mod_frame_enabled:                         1
mod_frame_refresh:                         30
thumb_2x:                                  1
small_2x:                                  1
medium_2x:                                 1
landing_page_enable:                       0
force_migration_in_production:             0
search_public:                             1
hide_version_number:                       1
SL_enable:                                 0
SL_for_admin:                              0
recent_age:                                7
grants_download:                           1
photos_wraparound:                         1
map_display:                               1
zip64:                                     1
map_display_public:                        1
map_provider:                              OpenStreetMap.org
force_32bit_ids:                           0
map_include_subalbums:                     1
update_check_every_days:                   3
has_exiftool:                              1
share_button_visible:                      0
import_via_symlink:                        0
has_ffmpeg:                                1
location_decoding:                         0
location_decoding_timeout:                 30
location_show:                             1
location_show_public:                      1
rss_enable:                                0
rss_recent_days:                           7
rss_max_items:                             100
prefer_available_xmp_metadata:             0
editor_enabled:                            1
lossless_optimization:                     1
swipe_tolerance_x:                         150
swipe_tolerance_y:                         250
local_takestamp_video_formats:             .avi|.mov
log_max_num_line:                          1000
unlock_password_photos_with_url_param:     0
nsfw_visible:                              1
nsfw_blur:                                 1
nsfw_warning:                              1
nsfw_warning_admin:                        1
nsfw_banner_override:                      
map_display_direction:                     1
album_subtitle_type:                       oldstyle
upload_processing_limit:                   6
new_photos_notification:                   0
legacy_id_redirection:                     1
zip_deflate_level:                         9
default_album_protection:                  1
album_decoration:                          layers
album_decoration_orientation:              row
allow_username_change:                     0
auto_fix_orientation:                      1
use_job_queues:                            0
random_album_id:                           starred
use_last_modified_date_when_no_exif_date:  0
layout:                                    justified
date_format_photo_thumb:                   M j, Y, g:i:s A e
date_format_photo_overlay:                 M j, Y, g:i:s A e
date_format_sidebar_uploaded:              M j, Y, g:i:s A e
date_format_sidebar_taken_at:              M j, Y, g:i:s A e
date_format_hero_min_max:                  F Y
date_format_hero_created_at:               M j, Y, g:i:s A T
date_format_album_thumb:                   M Y
upload_chunk_size:                         0
nsfw_banner_blur_backdrop:                 0
search_pagination_limit:                   25
search_minimum_length_required:            3
photo_layout_justified_row_height:         320
photo_layout_masonry_column_width:         300
photo_layout_grid_column_width:            250
photo_layout_square_column_width:          200
photo_layout_gap:                          12
display_thumb_album_overlay:               always
display_thumb_photo_overlay:               hover
default_album_thumb_aspect_ratio:          1/1
use_album_compact_header:                  0
login_button_position:                     left
back_button_enabled:                       0
back_button_text:                          Return to Home
current_job_processing_visible:            1
SA_random_thumbs:                          0
job_processing_queue_visible:              1
login_required:                            0
enable_unsorted:                           1
enable_starred:                            1
enable_recent:                             1
enable_on_this_day:                        1
login_required_root_only:                  1
dark_mode_enabled:                         1
show_keybinding_help_popup:                0
show_keybinding_help_button:               1
disable_se_call_for_actions:               0
enable_se_preview:                         0
slideshow_timeout:                         5
keep_original_untouched:                   1
hide_nsfw_in_smart_albums_and_search:      1

		

Browser & System [REQUIRED]

IceCat 115.16.1esr (64-bit) (Firefox ESR)
Firefox 131.0.2 (64-bit)
Librewolf 131.0.2-1

Linux 6.6.56-1-lts #1 SMP PREEMPT_DYNAMIC Thu, 10 Oct 2024 12:04:53 +0000 x86_64 GNU/Linux

Arch Linux

Please confirm (incomplete submissions will not be addressed)

• I have provided easy and step-by-step instructions to reproduce the bug.
• I understand my bug report will be removed if I haven't met the criteria above.

[ildyria]

That needs to be fixed indeed.

[ildyria]

Fix on its way: #2874