Implement fast drag drop support. #502
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhngtu
force-pushed
the
fastdrag
branch
2 times, most recently
from
8543115 to
826970c
Compare
|
I'm sorry for replying late because I'm busy on other coding things. For NanaZip.Modern, it may be simpler for integrating the shell extension than the NanaZip.Classic. But I need to refresh the NanaZip.ShellExtension implementation first before I merge this PR. I prefer the solution without shell extensions because I don't want to make shell extension for NanaZip.Classic because it's designed for portable app scenarios. Kenji Mouri |
|
When trying to integrate copy hook into NanaZip.Modern, I ran into the issue that packaged shell extensions cannot run outside of package due to conditional ACEs (#353 (comment)). That's why at the moment I've kept the extension external instead of building it into NanaZip.ShellExtension. |
|
when? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353 and #371.
Provides fast drag-to-extract support for NanaZip FM.
If the feature is enabled, dragging from the main window creates a directory with the name
{<COPYHOOK_GUID>}.<HWND>.Directories with this name are intercepted by an external copy hook shell extension DragNotifier, which sends back a WM_COPYDATA message containing the destination drop path.
Upon reception of WM_COPYDATA, NanaZip extracts selected files into the destination directory.
Todo list:
Due to many factors being undecided, this PR will remain a draft for now.
Feedback is welcome.