Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fitness report for Mageck output #20

Open
m-jahn opened this issue Feb 27, 2023 · 7 comments
Open

Add fitness report for Mageck output #20

m-jahn opened this issue Feb 27, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@m-jahn
Copy link
Member

m-jahn commented Feb 27, 2023

Description of feature

  • currently two reports are saved as ouput, 1x for counts, and 1x for Deseq2 fitness
  • with new Mageck module, also need 1x report for Mageck output or integrate QC/analysis in existing fitness report (.Rmd)
@m-jahn m-jahn added the enhancement New feature or request label Feb 27, 2023
@m-jahn m-jahn self-assigned this Feb 27, 2023
@m-jahn
Copy link
Member Author

m-jahn commented Apr 10, 2024

@ute-hoffmann are you using the Mageck output? Would it make sense for you to add fitness report for Mageck?

@ute-hoffmann
Copy link
Contributor

I'm currently usually not using Mageck, so not of real importance to me

@m-jahn
Copy link
Member Author

m-jahn commented Apr 10, 2024

OK good to know. Because it is too slow, or not informative?

@ute-hoffmann
Copy link
Contributor

Half of the projects I am working on are enzyme engineering projects where we do not have several sgRNAs targeting the same gene. Just realized that this might change for a larger library we'll work on, with several barcodes associated with one gene. So might be of interest.
And then, I think it crashed too frequently and I still wanted to read a bit more about the output it gives. And I always forgot to do so. But guess Mageck is probably giving a better analysis than the usual tests

@m-jahn
Copy link
Member Author

m-jahn commented Apr 10, 2024

And then, I think it crashed too frequently and I still wanted to read a bit more about the output it gives. And I always forgot to do so. But guess Mageck is probably giving a better analysis than the usual tests

I'm not sure about this. People use it but it seems it's not further developed apart from bug fixes maybe. And the performance is lousy. The DESeq and edger packages on the other hand are not made for this purpose but seem to do the task well

@ute-hoffmann
Copy link
Contributor

Hmm yeah I thought more about the adjusted p values assigned to different genes. With the Wilcoxon test, I always get pretty lousy adjusted p values and people claim one should only use it for more than (10?) replicates or so. Mageck might help with that

@m-jahn
Copy link
Member Author

m-jahn commented Apr 10, 2024

yes that's an issue. the rank sum test is not ideal for significance analysis, it produces too discrete (non-continuous) distributions. if you stumble over an alternative I'd be happy to hear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants