Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Themes #764

Open
Qainguin opened this issue May 28, 2024 · 4 comments
Open

Add Custom Themes #764

Qainguin opened this issue May 28, 2024 · 4 comments
Labels

Comments

@Qainguin
Copy link
Contributor

There should be a way to add custom themes to GodSVG.
My idea was that there should be a singleton with all of the theme colors included and to put them in the already existing color changer on the settings popup.

@MewPurPur
Copy link
Owner

MewPurPur commented May 28, 2024

From the onset, I somewhat agree with the idea of splitting off a singleton for the things needed to configure a theme. But I'd like to see what a theming system would look like in practice or describe it in detail, before deciding on such an infrastructure. For example, will colors be configurable or will there just be a dictionary for interfacing with pre-made themes? Would a theming database could include things like fonts, enums for spacing, roundiness, other little numbers? (almost for sure it won't be all colors.)

tl;dr: Full agreement on custom themes. The internal specifics should come after the implementation or an agreed on specification.

@Qainguin
Copy link
Contributor Author

The theming database would most likely just be for colors but could be added to later and if possible people should be able to share a single file for getting a custom theme.

@MewPurPur
Copy link
Owner

MewPurPur commented May 28, 2024

should be able to share a single file for getting a custom theme

Like the "Copy as XML" function for palettes? I think that'd work fine for this too.

@Qainguin
Copy link
Contributor Author

Yeah, pretty much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants