Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework gui control app #23

Closed
sajjadG opened this issue Oct 21, 2023 · 16 comments
Closed

Rework gui control app #23

sajjadG opened this issue Oct 21, 2023 · 16 comments
Assignees
Labels
enhancement New feature or request

Comments

@sajjadG
Copy link

sajjadG commented Oct 21, 2023

I'm getting this error on a windows 11 VM installed in hyper-v on windows 11.
Screenshot from 2023-10-21 15-34-02

trying to use this virual display to increase the resolution of this VM created via easy-gpu-pv script.

@MolotovCherry
Copy link
Owner

MolotovCherry commented Oct 21, 2023

I really couldn't say what's wrong in your VM, but opengl is pretty standard for any device which has gpu support (amd/nvidia/intel all support it as usual). I'd check that your gpu support/drivers are properly functioning and set up for opengl in the vm. (This is a windows/gpu/gpu driver/windows software issue)

If you figure out the fix for your issue, let me know, I might be able to add it to a FAQ

@sajjadG
Copy link
Author

sajjadG commented Oct 21, 2023

Oh sorry. I just remembered about Hyper-V GPU-P not working fine with OpenGL. It's been created to work good with directx. They've mentioned it in their notes:

Vulkan renderer is unavailable and GL games may or may not work. This may help with some OpenGL apps.

GPU-P is a way to partition your graphic card into smaller parts using hyper-v technology. So this bug is not related to your app directly. probably egui guys can fix it not using opengl in windows but that's something they have to decide.

Thanks for your fast response <3
Cheers

@MolotovCherry
Copy link
Owner

MolotovCherry commented Oct 21, 2023

I see! As a side note to this, I'd prefer my control app not to require opengl in the first place, though that'd require finding a better solution for a gui library

@MolotovCherry
Copy link
Owner

MolotovCherry commented Oct 21, 2023

Due to the state of ui libraries, I don't see any real option for the soon forseeable future. I'll keep this on my mind for now, but it may be a very long time - if I ever rewrite it due to this

How does a cli sound though?

@updawg
Copy link

updawg commented Oct 22, 2023 via email

@MolotovCherry MolotovCherry added the enhancement New feature or request label Oct 22, 2023
@MolotovCherry MolotovCherry changed the title egui_glow requires opengl 2.0+ make cli control app Oct 22, 2023
@MolotovCherry
Copy link
Owner

For those of you with this error, can you do something for me?

In your vm or whatever that doesn't support opengl, how does this website look and perform to you?
https://www.egui.rs/

@updawg
Copy link

updawg commented Oct 23, 2023

Looks fine to me: https://imgur.com/a/r2B1BEU

This is from a hyper-v VM connected via parsec

@MolotovCherry MolotovCherry self-assigned this Oct 26, 2023
@MolotovCherry
Copy link
Owner

Windows native app is in the works, which will solve all these problems, plus look much better.

image

@updawg
Copy link

updawg commented Nov 10, 2023 via email

@sajjadG
Copy link
Author

sajjadG commented Nov 10, 2023

Windows native app is in the works, which will solve all these problems, plus look much better.

image

when will this be released?

@MolotovCherry
Copy link
Owner

MolotovCherry commented Nov 10, 2023

Windows native app is in the works, which will solve all these problems, plus look much better.

when will this be released?

I have no set dates right now. IPC itself works under the hood, and I just finished the settings page and making theming and materials work properly.

The rest to do is implement the actual monitor interface.

A ton of changes went into the driver under the hood to make it better as far as ipc, and to support functioning well with a gui (which now the underlying gui will no longer accidentally get out of sync with the driver). It has taken some time to work through so many changes.

Then the build system has to be re-adjusted, installer changed, and I might have to re-issue a new certificate.

The app should no longer require admin access either (which is a plus)

@sajjadG
Copy link
Author

sajjadG commented Nov 10, 2023

Good work @MolotovCherry <3

@the-epoch
Copy link

the-epoch commented Nov 23, 2023

I have this same error on a physical machine (not a VM) that is headless (ie. no monitors attached).
From the text in the error, this appears to be a problem with the path - "c:\Users\runneradmin... " definitely does not exist in m,y build.
This path seems to be hard coded somewhere.
2023-11-23 155546 virtualdisplayrs error
This was after a reboot and installing a new Virtual Display driver.
I uninstalled both Virtual Displays, removing the driver, rebooted and reinstalled and still get same error.
2023-11-23 160619 virtualdisplayrs error after uninstall

@MolotovCherry
Copy link
Owner

MolotovCherry commented Nov 23, 2023

@the-epoch This is a fault of the graphics driver on the system, or something to do with Windows. If your system is headless, that may be why. Opengl is pretty standard for any system which supports graphics.

I am making a different gui app for this which does not require opengl, but for now, there is no way to solve that unless you can solve the underlying issue in your drivers/os.

As for the path, that is unrelated. That just says what file in the build is raising the error, so it can be looked up in the source files for debugging. The problem is what I said above ^

@MolotovCherry
Copy link
Owner

Cli app done in #43 (with scheduled improvements in #48)

@MolotovCherry MolotovCherry changed the title make cli control app Rework gui control app Dec 6, 2023
@MolotovCherry
Copy link
Owner

Closing in favor of #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants