Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for esm modules #607

Open
aorinevo opened this issue Sep 14, 2023 · 0 comments
Open

Add support for esm modules #607

aorinevo opened this issue Sep 14, 2023 · 0 comments
Assignees
@aorinevo

Comments

@aorinevo
Copy link
Collaborator

Plan

  1. Create a separate tsc configuration file (e.g., tsconfig.esm.json)
  2. Upgrade ora and log-symbols to latest version (both have dropped support for cjs on latest)
  3. In package.json set type to module
  4. Try to support both cjs and esm distributions; however, ora and log-symbols will require use of dynamic imports.
  5. This is a breaking change; ensure commit message includes BREAKING_CHANGE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aorinevo aorinevo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(build): migrate to esm from cjs BREAKING_CHANGE NerdWalletOSS/shepherd
1 participant
@aorinevo