Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use localized string representation of numbers #2372

Open
Pickysaurus opened this issue Dec 12, 2024 · 2 comments
Open

Use localized string representation of numbers #2372

Pickysaurus opened this issue Dec 12, 2024 · 2 comments
Labels
Design UI/UX This is related to the UI. meta-improvement An issue that improves an existing feature

Comments

@Pickysaurus
Copy link
Contributor

Improvement

Relates to #1694

Currently

When we show larger numbers in the app, we don't comma-separate them. (e.g. 1000)

We want

To add comma-separation for consistency with the website.

We may need to discuss localisations here, as in some countries they use decimal places instead of commas (1.000 instead of 1,000)

Supporting Information

(Include any supporting screenshots etc to support the above)

Design

(Any designs to required for this feature)

@Pickysaurus Pickysaurus added Design UI/UX This is related to the UI. meta-improvement An issue that improves an existing feature labels Dec 12, 2024
@erri120 erri120 changed the title Use comma separation for large numbers Use localized string representation of numbers Dec 12, 2024
@erri120
Copy link
Member

erri120 commented Dec 12, 2024

Image

The default integer representation uses the "general format" (G). We probably want N for numbers.

@MattSturgeon
Copy link
Contributor

We may need to discuss localisations here, as in some countries they use decimal places instead of commas (1.000 instead of 1,000)

I know in Java there's a "localized number format(er)" that can use comma, dot, apostrophe, etc as appropriate for the current l10n. Presumably .NET has something similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design UI/UX This is related to the UI. meta-improvement An issue that improves an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants