Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discoloured mod thumbnails in Library #2411

Open
insomnious opened this issue Dec 19, 2024 · 0 comments
Open

Discoloured mod thumbnails in Library #2411

insomnious opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
Bug Something isn't working

Comments

@insomnious
Copy link
Collaborator

Bug Report

Summary

(Summarize the bug encountered concisely ensuring you state the current behaviour)

When displaying mod images on the Library page (thumbnails-in-pages branch), the images have a blue tinge to them.

Steps to reproduce

When running the thumbnails-in-pages build...

  • Install a mod
  • Go to Library page
  • Thumbnail next to Name doesn't match the one online

What is the expected behaviour?

The image matches the one found on the site.

Other information

I did some quick research into the issue and it is stemming from how we Encode and Decode the image from the site into and out of our database.

https://github.com/Nexus-Mods/NexusMods.App/blob/thumbnails-in-pages/src/NexusMods.App.UI/ImagePipelines.cs#L174-L174

When I changed CreateModPageThumbnailPipeline() in the ImagePipeline to use SkiaWebp to Encode\Decode, the images work fine.

When using QoI, if I manually set DecodeQoi() as Bgra8888 instead of Rgba8888, it also works.

Currently

Image

Should be

Image

Log files can be found in these locations:

  • Windows: %LOCALAPPDATA%\NexusMods.App\Logs
  • Linux: ~/.local/state/NexusMods.App/Logs

Please attach both nexusmods.app.main and nexusmods.app.slim log files with the most recent dates.

@insomnious insomnious added the Bug Something isn't working label Dec 19, 2024
@insomnious insomnious added this to MVP Dec 19, 2024
@insomnious insomnious changed the title Image format for mod images Discoloured mod thumbnails in Library Dec 19, 2024
@erri120 erri120 self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants