Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Added a Pandas based Transformation and BaseTransformation #141

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dannymeijer
Copy link
Member

@dannymeijer dannymeijer commented Dec 1, 2024

Also added an ml extra dependency which should allow DBR 13, 14 and 15 ML support; this should be installed using koheesio[ml]

Related Issue

#79

Motivation and Context

  • Support ML type work
  • Allow Transformation type contributions on the pandas module

To do

  • Run tests on DBR
  • Make an env without ml extra to ensure that koheesio core works as intended
  • Make an env without spark to ensure the lib works as intended when not using spark

How Has This Been Tested?

Added unit tests. Integration tests on ML pipelines still needed.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dannymeijer dannymeijer requested a review from a team as a code owner December 1, 2024 11:48
@dannymeijer dannymeijer linked an issue Dec 1, 2024 that may be closed by this pull request
@dannymeijer dannymeijer added this to the 0.10.0 milestone Dec 1, 2024
@dannymeijer dannymeijer added enhancement New feature or request blocked labels Dec 1, 2024
@dannymeijer dannymeijer self-assigned this Dec 1, 2024
@dannymeijer
Copy link
Member Author

Marking this as blocked based on the To Do's I mentioned

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newly added is ml - I sorted the features afterwards

@dannymeijer dannymeijer changed the title [FEATURE] Added a Pandas based Transformtion and BaseTransformation [FEATURE] Added a Pandas based Transformation and BaseTransformation Dec 1, 2024
@dannymeijer dannymeijer marked this pull request as draft December 20, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

[FEATURE] DBR ML Support
1 participant