Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no 404 page. #201

Closed
bytesagar opened this issue Jun 11, 2020 · 3 comments
Closed

There is no 404 page. #201

bytesagar opened this issue Jun 11, 2020 · 3 comments
Assignees
@lirantal @UlisesGascon

Comments

@bytesagar
Copy link

Added 404 page, if the page is not found
@UlisesGascon UlisesGascon self-assigned this Jun 13, 2020
@UlisesGascon
Copy link
Collaborator

Hi @sagar608!

Thanks for open this issue and fix the 404 missing page in a PR.

We are working now in the Lerna implementation #187. Once the PR #189 is merged the project setup will change in a new folder structure.

Can you create a PR for the 404 based on branch feature/187? The CI should work fine and prevent linting issues.

@UlisesGascon UlisesGascon mentioned this issue Jun 13, 2020
Open
@bytesagar
Copy link
Author

Thank you @UlisesGascon
If you could help me on how can I create a new PR on branch > feature/187 ?

@lirantal
Copy link
Collaborator

lirantal commented Mar 6, 2023

Let's take it with the created PR

@lirantal lirantal closed this as completed Mar 6, 2023
@lirantal lirantal self-assigned this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lirantal lirantal

@UlisesGascon UlisesGascon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lirantal @UlisesGascon @bytesagar