From 58f7fa8e77693e34ebc43655af56b14a47958229 Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Fri, 24 Feb 2023 17:26:16 +0000 Subject: [PATCH 1/4] Test building without Python lint tools --- .github/workflows/lint.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 33882f0bf4..7f654a98d3 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -23,8 +23,8 @@ jobs: apt-get -y install pkg-config libtool autoconf \ automake g++ bison flex make bash-completion dh-autoreconf \ debhelper devscripts wget python3-pip - - name: Install Python lint tools - run: python3 -m pip install --no-input cpplint flake8 + #- name: Install Python lint tools + # run: python3 -m pip install --no-input cpplint flake8 - name: Install build dependencies shell: bash run: | From 4a77dcd52fbcca26ae62d8b28c49358a0e17447f Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Fri, 24 Feb 2023 17:34:17 +0000 Subject: [PATCH 2/4] Fix some whitespace around the cpplint error --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index f488cf71a1..0b5e88271d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -261,5 +261,5 @@ cpplint: Makefile.am if FOUND_CPPLINT cpplint --filter=$(CPP_LINT_FILTER) $(CPP_LINT_FILES) else - $(error cpplint not found. Install forked cpplint (e.g. via pip for the latest version) and re-run configure.) + $(error cpplint not found. Install the forked cpplint (e.g. via pip for the latest version) and re-run configure.) endif From 7b4a27361db2cd2ec46ff21d84cf82f4a589ee3c Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Fri, 24 Feb 2023 18:15:00 +0000 Subject: [PATCH 3/4] Add back in the missing dependencies for configure --- .github/workflows/lint.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 7f654a98d3..33882f0bf4 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -23,8 +23,8 @@ jobs: apt-get -y install pkg-config libtool autoconf \ automake g++ bison flex make bash-completion dh-autoreconf \ debhelper devscripts wget python3-pip - #- name: Install Python lint tools - # run: python3 -m pip install --no-input cpplint flake8 + - name: Install Python lint tools + run: python3 -m pip install --no-input cpplint flake8 - name: Install build dependencies shell: bash run: | From 688cfe1c2c5980c87b23376a74b6943447bb6b8b Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Fri, 24 Feb 2023 18:38:11 +0000 Subject: [PATCH 4/4] Try drastically trimming some dependencies --- .github/workflows/lint.yaml | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 33882f0bf4..d1a1188c08 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -136,18 +136,9 @@ jobs: - name: Install build tools shell: bash run: | - apt-get -y install pkg-config libtool autoconf \ - automake g++ bison flex make bash-completion dh-autoreconf \ - debhelper devscripts wget python3-pip + apt-get -y install make python3-pip - name: Install Python lint tools - run: python3 -m pip install --no-input cpplint flake8 - - name: Install build dependencies - shell: bash - run: | - apt-get -y install libcppunit-dev uuid-dev libncurses5-dev \ - libmicrohttpd-dev protobuf-compiler python3-protobuf \ - libprotobuf-dev libprotoc-dev zlib1g-dev libftdi-dev \ - libusb-1.0-0-dev liblo-dev libavahi-client-dev python3-numpy + run: python3 -m pip install --no-input cpplint - name: Enable Problem Matcher for GitHub annotations run: echo "::add-matcher::.github/problem-matcher-lint-cpplint.json" - name: cpplint @@ -178,20 +169,11 @@ jobs: - name: Install build tools shell: bash run: | - apt-get -y install pkg-config libtool autoconf \ - automake g++ bison flex make bash-completion dh-autoreconf \ - debhelper devscripts wget python3-pip + apt-get -y install make python3-pip - name: Install Python lint tools - run: python3 -m pip install --no-input cpplint flake8 + run: python3 -m pip install --no-input flake8 - name: Setup flake8 annotations uses: rbialon/flake8-annotations@v1 - - name: Install build dependencies - shell: bash - run: | - apt-get -y install libcppunit-dev uuid-dev libncurses5-dev \ - libmicrohttpd-dev protobuf-compiler python3-protobuf \ - libprotobuf-dev libprotoc-dev zlib1g-dev libftdi-dev \ - libusb-1.0-0-dev liblo-dev libavahi-client-dev python3-numpy - name: flake8 run: make flake8 VERBOSE=1 spellintian: