-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category descriptions #2577
Comments
Yeah, good question… Most categories were inherited from QLC+'s fixture types, but we added the possibility to add multiple categories to a single fixture to make it more expressive. However, there has never been a clear definition or description which fixtures belong to which categories.
I guess we currently don't have any of these dimmers / dimmer packs in OFL. But that'd probably make sense. (See also #694.)
But not all effect lights or fog machines have a dimmer channel.
Often called "Moonflower". It's a single light fixture that produces many beams in different directions and often different colors: https://www.ecosia.org/images?q=moonflower%20lighting
The distinction is not always clear. E.g. the cameo Thunder Wash 600 RGB can be used as a strobe, as a flood light or as a blinder. But in general, the "Strobe" category should only be applied to fixtures that are sufficiently bright and look light a Strobe light, not every moving head or PAR LED that has a strobe channel.
I don't really know. I think Haze is less dense than Fog (and I don't know why that's called "Smoke" in QLC+) and usually used to make laser beams more visible. Maybe a hazer has to have an included fan to better distribute the haze, while a fog machine is an effect device itself, so the nozzle should usually be visible to the audience.
Barrel scanners have a rotatable (Pan/TiltContinuous) cylinder with multiple mirrors: https://www.ecosia.org/images?q=barrel%20scanner
I think we can't put it in the categories
I currently don't have the time to come up with exact definitions. I'm open for suggestions though! If you'd like to try, I can answer specific questions to my best knowledge (like in this comment). |
We actually do! At least
Yeah, I'm torn on this. On the one hand, when building a lighting plot, it sure would be nice to have beam angles and weight and lumens for the conventionals, too. On the other hand, these don't really fit well in the OFL schema, and it would greatly increase the scope of the project, and most of the conventionals I encounter don't have easily available specifications.
I'll try to come up with rough definitions for you to vet. (Maybe QLC has descriptions, since they created the category names? I'll check.) (UPDATE: Nope, they don't.) Pictures are really helpful here. Even simply knowing that "flower" (hard to search) is also called "moonflower" was useful. The category icons are great, once you know what they are, but at the point where we ask a user to select a category, perhaps we could display an image of a canonical example of each. |
I've created a rough draft (in #3358) of some descriptions for the 17 categories, and picked an example for each. I tried to pick examples which:
Not all categories were clear to me, and I have some questions:
Also, I still think that it would be helpful to have a couple more categories:
Feedback welcome! |
An issue I've seen a few times: if a fixture's only color capability is "warm white" to "cool white", is it considered a "color changer"? I don't know that I've ever seen an authoritative definition of "color changer", but my gut says no. |
That looks sorta right. I'll comment concrete suggestions in the PR.
That was actually never really defined. But I'd say a water-styled lighting effect should belong to the "Effect" category.
Yes, I think of it that way.
Not necessarily, e.g. pyro/flame effects should also be in the "Effects" category. Maybe it might make sense to add a new "Pyro" category? UV-only fixtures are basically dimmers in a different color, so they don't really belong into any other category. So maybe also add a new "UV" category?
See my answer in #694.
Sounds good 👍
My gut also says no 🙂 |
FWIW, today I noticed that the validator (which has no gut) will flag a warning "Category 'Color Changer' suggested since there are ColorPreset or ColorIntensity capabilities or Color wheel slots." when the only color-related capabilities are ColorIntensity channels "Cold White" and "Warm White". |
One of the issues I'm seeing with using OFL data is that the categories are not consistently applied, and I think that stems from there being no description of exactly what the categories mean.
For example, wearing my lighting technician hat, I would say a "Dimmer" is a device which takes DMX input, and provides PWM-dimmed power (probably over Edison, Socapex, or stage pin), i.e., PWM. But most of the fixtures in OFL which include category "Dimmer" aren't this type of dimmer at all. I think some people assumed it means "any fixture which has an Intensity channel" (which is a little silly since that's probably every DMX fixture ever made).
I think that, in almost every case, a device with category "Dimmer" should not have any other category (see #914).
I started to make a big PR which removed "Dimmer" from dozens of fixtures, and I realized there's a more general issue: I don't know what some of the other categories mean, either. (What's a "Flower"? Is "Strobe" simply anything that has a Strobe channel? What's the difference between "Smoke" and "Hazer"? Or "Scanner" and "Barrel Scanner"? I rarely work with those kinds of fixtures myself.)
So it would be great to have clarification on what the categories are intended to mean, and then I'll help clean up the data so they're accurate. Ideally, the descriptions would be in the docs (schemas?), and also visible in the web editor. Thanks!
The text was updated successfully, but these errors were encountered: