Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'must be stepped' for WheelSlotRotation's slotNumber #3625

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add 'must be stepped' for WheelSlotRotation's slotNumber #3625

wants to merge 2 commits into from

Conversation

Breina
Copy link
Contributor

@Breina Breina commented Nov 13, 2023

Fix #3624

FloEdelmann
FloEdelmann requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. I think your proposed change is wrong, since slotNumber doesn't actually need to be stepped (according to both the JSON Schema and the code implementation). However, you could explain in the slotNumber footnote that using it is discouraged for the WheelSlotRotation capability type.

@FloEdelmann FloEdelmann added the documentation Improves the Markdown docs, or in-code JSDoc comments, or user documentation on the website. label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation Improves the Markdown docs, or in-code JSDoc comments, or user documentation on the website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion: Should WheelSlotRotation's slotNumber be stepped?
2 participants
@Breina @FloEdelmann