Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation suggestion: minimum size #4012

Open
kengruven opened this issue Jun 9, 2024 · 0 comments
Open

Validation suggestion: minimum size #4012

kengruven opened this issue Jun 9, 2024 · 0 comments
Labels
component-test Affects the automated tests.

Comments

@kengruven
Copy link
Contributor

The physical dimensions in OFL are measured in millimeters, but it's very common for contributors to enter centimeters by mistake.

The barrel of a DMX connector is just under 2cm in each dimension. Therefore, if the dimensions of a fixture are less than [30, 30, 30], it's almost certainly a mistake.

It seems like it would be easy to add a validation rule that says: if size is smaller than [30, 30, 30], and DMXconnector contains "3-pin" or "5-pin", then flag an error. (There may be really thin fixtures which are controlled wirelessly, so I wouldn't want to preclude the possibility of all tiny fixtures -- just tiny fixtures which also claim to have DMX jacks that would be as big as the fixture itself.)

@FloEdelmann FloEdelmann added the component-test Affects the automated tests. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Affects the automated tests.
Projects
None yet
Development

No branches or pull requests

2 participants