Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation suggestion: equal start/end properties #4435

Open
FloEdelmann opened this issue Nov 25, 2024 · 0 comments
Open

Validation suggestion: equal start/end properties #4435

FloEdelmann opened this issue Nov 25, 2024 · 0 comments
Labels
component-test Affects the automated tests.

Comments

@FloEdelmann
Copy link
Member

See e.g. https://github.com/OpenLightingProject/open-fixture-library/pull/4095/files#r1683070719:

{
  "dmxRange": [10, 39],
  "type": "ColorTemperature",
  "colorTemperatureStart": "1800K",
  "colorTemperatureEnd": "1800K"
}

This should be reported, and instead this should be encouraged:

{
  "dmxRange": [10, 39],
  "type": "ColorTemperature",
  "colorTemperature": "1800K"
}
@FloEdelmann FloEdelmann added the component-test Affects the automated tests. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Affects the automated tests.
Projects
None yet
Development

No branches or pull requests

1 participant