Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a manufacturer name doesn't force a version bump of the manufacturer data #65

Open
peternewman opened this issue Dec 7, 2016 · 2 comments
Labels

Comments

@peternewman
Copy link
Member

http://rdm.openlighting.org/download?pids=manufacturers

@peternewman peternewman added the bug label Dec 7, 2016
@peternewman
Copy link
Member Author

@peternewman
Copy link
Member Author

This will probably do the trick, needs testing though:

query.filter('name IN ', (timestamp_keys.PIDS, timestamp_keys.MANUFACTURERS)
query.order('-update_time')

The only minor downside, is a name change on a manufacturer who doesn't have any PIDs causes the timestamp to be updated, but it's probably not really worth trying to fix this edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant