Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SOCD settings to be stored alongside a Profile #1187

Open
j-zhao opened this issue Oct 4, 2024 · 3 comments
Open

Allow SOCD settings to be stored alongside a Profile #1187

j-zhao opened this issue Oct 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@j-zhao
Copy link

j-zhao commented Oct 4, 2024

Please read these quoted sections before submitting, and remove them (including this one) when you have provided what
is asked, in order to make addressing the issue easier for everyone. Thank you!

Be sure to:

  • Check the documentation HERE to answer many questions on firmware capabilities and usage.
  • Make sure that your idea has not already been filed HERE.
  • Confirm the feature does not exist in the latest version of the firmware, found
    HERE.

Problem

Different games have different optimal SOCD resolution (e.g. neutral for SF6, vs SOCD-U for tag fighters). Often times, this warrants changing a profile as well as inputting a shortcut on the device to change SOCD.

Solution

Store SOCD settings alongside a profile. This allows a few improvements:

  • Reducing one less device input to change SOCD alongside changing profiles
    • Intuitively, this makes it very easy to set-it-and-forget-it for each game
    • With the recent 0.7.10 release, custom profile names will benefit displays. Seeing the correct profile on your device display is insurance that your SOCD is set correctly, instead of managing two changes on first-plug.

Do you plan to work on this feature yourself?

Yes. I will create a PR to kick things off, and will engage w/ the community and Discord to get this merged.

Notes

@j-zhao j-zhao added the enhancement New feature or request label Oct 4, 2024
@j-zhao
Copy link
Author

j-zhao commented Oct 4, 2024

Mockup:
Add one additional setting to default to Global Gamepad setting
image

@bsstephan
Copy link
Contributor

As a breadcrumb you will be looking at adding something new to ProfileOptions in the protobuf structure. I don't have an opinion currently on if that should be more GamepadOptions (most fields of which would be ignored in the profiles) or a new structure (which might suggest GamepadOptions needs a refactoring) but be aware that is a critical element of how to do this.

@febs
Copy link

febs commented Dec 6, 2024

Would it be feasible to also save the rgb led profile as well? Thank you for reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants