Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Do not set language globally, but read it from Browser/User Preferences #26

Open
t-oster opened this issue Jul 12, 2012 · 2 comments

Comments

@t-oster
Copy link

t-oster commented Jul 12, 2012

Hi,

I implemented a language system very similar to this one at work. However I don't think it makes much sense to set the language in the preferences. I propose, that you try to guess the best language from the client's browser language. I also suggest a panel with "flag"-symbols for all installed languages, so once a user is on that page, he/she can change the language on the fly. I would then save this language in the session and for logged-in users also in the database.

If most of you agree with this idea, I can help implement it. I don't think it will be much effort, because I already have functions to get language from the browser, a few language Icons and you already have the option to load a language.

cheers

T

@t-oster
Copy link
Author

t-oster commented Jul 12, 2012

sorry, dup of #4 . but still i'd like to help

@jasperf
Copy link
Member

jasperf commented Jul 13, 2012

You have my vote. Sounds like a good idea. And we did discuss a language picker before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants