Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Logging not working with crypto_algorithm==NONE #24155

Open
jnippula opened this issue Dec 27, 2024 · 0 comments · May be fixed by #24156
Open

[Bug] Logging not working with crypto_algorithm==NONE #24155

jnippula opened this issue Dec 27, 2024 · 0 comments · May be fixed by #24156

Comments

@jnippula
Copy link
Contributor

jnippula commented Dec 27, 2024

Describe the bug

If PX4_CRYPTO is defined and the param SDLOG_ALGORITHM is set 0 (Disabled), the logging does not start due to file not found error. If crypto algorithm is not given the symmetric key is not created and not stored into the beginning of the log file, so the file is not found when log data is tried to be appended after the key data.

To Reproduce

  1. Build px4_fmu-v5_cryptotest image and flash it
  2. Boot up the device
  3. Set param SDLOG_ALGORITHM -> 0
  4. Reboot the device
  5. command: logger on

Expected behavior

Logging is started without encryption. Afters logging is stopped the log file will containsplain text ulog data.

Screenshot / Media

No response

Flight Log

No response

Software Version

PX4-Autopilot main branch. Bug noticed with commit b765769 (Note! This commit did not break the logging, but it is just one commit with which the bug was detected. The breaking change is this one: 2da944a)

Flight controller

px4_fmu-v5

Vehicle type

None

How are the different components wired up (including port information)

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant