Bump minimum velocity version to 21 #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump minimum velocity version to 21
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
that commit looks like it was made to be compatible with versions <21 and the defined toolchain is still Java 17, so I'd appreciate it if someone from the Velocity team could weigh in here (cc @4drian3d) maybe it'd be worth to specify a different recommended version beside the minimum version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minimum velocity version to 21. It appears intentional that Velocity is ran with at least Java 21 since parts of the code base rely on specific Java 21 features. Such as commit PaperMC/Velocity@ecf936f.