Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in the lastest version of Rhino licensing #929

Closed
andreasohlund opened this issue Jan 29, 2013 · 9 comments
Closed

Pull in the lastest version of Rhino licensing #929

andreasohlund opened this issue Jan 29, 2013 · 9 comments
Assignees
Milestone

Comments

@andreasohlund
Copy link
Member

To fix this issue:

ayende/rhino-licensing#5

@ghost ghost assigned johnsimons Jan 30, 2013
@johnsimons
Copy link
Member

I think we should do the same as Raven and include the source instead of referencing assembly and ilmerge

@DrivenLogic
Copy link

It's not the best bit of code I have ever read... I think you might be better off cutting it back and bring in just the bits you need.

@johnsimons
Copy link
Member

That's the plan 😄

@andreasohlund
Copy link
Member Author

Makes sense

Sent from my iPhone

On 30 jan 2013, at 06:52, John Simons [email protected] wrote:

That's the plan


Reply to this email directly or view it on GitHub.

@SimonCropp
Copy link
Contributor

looking at the code base nist1.sjc.certifiedtime.com has already been removed. so this should be closed?

Having said that checking internet time for an open source + non-obfuscated project is a lesson in pointlessness.

@andreasohlund
Copy link
Member Author

Yes, we decided to remove the timecheck

Sent from my iPhone

On 3 feb 2013, at 01:20, Simon Cropp [email protected] wrote:

looking at the code base nist1.sjc.certifiedtime.com has already been removed. so this should be closed?

Having said that checking internet time for an open source + non-obfuscated project is a lesson in pointlessness.


Reply to this email directly or view it on GitHub.

@DrivenLogic
Copy link

Just an FYI: I can't specifically pin point the problem ATM. But I noticed on my fork that when I removed the time check, stability problems with WCF hosting went away.

@johnsimons
Copy link
Member

Done in c31efa5

@DrivenLogic
Copy link

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants