You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suggest redefining USBHost::print_hexbytes() as USBHost::prn_hex() and just #define print_hexbytes() either as prn_hex() or as nothing. This way we can use the static function USBHost::prn_hex() to do hex dump while all the debug print lines in the existing code are still controlled by USBHOST_PRINT_DEBUG.
The text was updated successfully, but these errors were encountered:
Note: @PaulStoffregen has the final say on some of these api changes...
But I don't think you want to blindly make the hex debug code built in there dump all of the time without that define, unless we instead have the dump code maybe public an the current hex dump dump call, only call it when in that state, otherwise we will suddenly have a lot more debug printing when we are not configured for debug...
Just an FYI, there are lots of hex dump functions, out there, but I have one that I hacked up that I use for debugging. https://github.com/KurtE/MemoryHexDump
Nothing very special, but does have hacks in it that if it finds lots of rows would be duplicated, it can optionally remove those lines.
USBHost_t36/USBHost_t36.h
Line 317 in d41ed87
Suggest redefining USBHost::print_hexbytes() as USBHost::prn_hex() and just #define print_hexbytes() either as prn_hex() or as nothing. This way we can use the static function USBHost::prn_hex() to do hex dump while all the debug print lines in the existing code are still controlled by USBHOST_PRINT_DEBUG.
The text was updated successfully, but these errors were encountered: