Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt + routing #6

Open
GinoPane opened this issue Aug 7, 2020 · 8 comments
Open

Bolt + routing #6

GinoPane opened this issue Aug 7, 2020 · 8 comments

Comments

@GinoPane
Copy link

GinoPane commented Aug 7, 2020

Hi guys!
Just to confirm. Does this library version work with bolt+routing scheme?

@matas-valuzis
Copy link

Not yet, but you're welcome to submit a PR. Personally I'm not too interested in writing support for cluster features since I don't use those and its hard to write test for them, but this might change in the future.

@GinoPane
Copy link
Author

@matas-valuzis I'd love to but have no experience in writing a driver (yet). Do you maybe have any suggestions where to look at to be able to add new protocols?

@matas-valuzis
Copy link

@GinoPane I think best place to start is to take a look at existing driver implementation (i.e js driver). After having a clear vision how it should work, write some tests for it. If you manage to set up proper tests I can help you with the rest.

@hidabe
Copy link

hidabe commented Feb 23, 2021

Hi, using: CALL dbms.cluster.overview() you can return LEADER server, and you can use it... but it not is routing :(

I am trying implement it too, have you any progress @GinoPane ?
Any help more, @matas-valuzis ?

Thanks!

@hidabe
Copy link

hidabe commented Feb 25, 2021

hi again, i think that the decision about what server from cluster use is from neo-client, not neo-bolt, i have added this feature to my connection: https://github.com/hidabe/neo4j-php-client/blob/master/src/Connection/Connection.php it work using "bolt+routing" in schema uri

@GinoPane
Copy link
Author

@hidabe tbh I got routing logic wrong and I imagined that routing is done automatically by neo4j itself when we specify bolt+routing and we just need to send requests in some "special" way using the driver

@hidabe
Copy link

hidabe commented Feb 26, 2021

Thanks @GinoPane, what do you thing of the solution of my proposal? Is it responsability of client (no neo4j-bolt driver)? What do you thing? Regards

@GinoPane
Copy link
Author

@hidabe if we refer to Neo4j itself, routing should be done in driver. But in our case this package and relevant client are implemented in a way when routing via client seems feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants