Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature req: Buddy task #10

Open
beltoft opened this issue Sep 14, 2016 · 7 comments
Open

Feature req: Buddy task #10

beltoft opened this issue Sep 14, 2016 · 7 comments

Comments

@beltoft
Copy link

beltoft commented Sep 14, 2016

Short Description

A new task to select a buddy pokemon

Possible solution

a task named buddy where you could put in the name of the pokemon you would select as buddy.

How it would help others

it will give extra candy for the type of pokemon you chose as buddy for every km walked making it easier to evolve that type

@DeXtroTip
Copy link
Contributor

I'm working on it, I'm running some tests before making a PR

@tohyf
Copy link

tohyf commented Sep 14, 2016

if a buddy is already selected would it require additional API calls to "walk" it ?

@DeXtroTip
Copy link
Contributor

There is an api call to get the reward, not sure if reward is got without it, maybe not

@tohyf
Copy link

tohyf commented Sep 14, 2016

Looks like the distance is being recorded down correctly, I guess the only question is whether the candy reward requires another API call

@DeXtroTip
Copy link
Contributor

It might be like CollectLevelUpRewards or IncubateEggs, if you don't make the api call you don't get the rewards, I guess

@cowst
Copy link

cowst commented Sep 14, 2016

That's the case, since there is another open issue exactly for that :)

@DeXtroTip
Copy link
Contributor

Yeah, I've checked it already. Added check on task to get old rewards from current buddy.
Need to update docs/configuration_files.md before PR and the api also has a bug on buddy api calls, I had to fix it manually, we'll need to wait for them to merge the fix too before this task works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants