Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented behaviour for mass releasing features #29

Open
pcasaretto opened this issue Dec 19, 2016 · 2 comments
Open

Undocumented behaviour for mass releasing features #29

pcasaretto opened this issue Dec 19, 2016 · 2 comments

Comments

@pcasaretto
Copy link
Contributor

Currently, release accepts an array and because Redis.scard accepts it as well it ends ups releasing that feature to all ids present in the array.
This is undocumented behaviour and future storage options might not implement this.

> FeatureFlagger.control.release("feature1", [1,2,3])
> FeatureFlagger.control.rollout?("feature1", 1) #=> true
> FeatureFlagger.control.rollout?("feature1", 2) #=> true
> FeatureFlagger.control.rollout?("feature1", 3) #=> true
@nsoufr
Copy link
Contributor

nsoufr commented Mar 18, 2017

Wowwwwwwwwww

@nsoufr
Copy link
Contributor

nsoufr commented Mar 5, 2020

After almost three years of thinking...

We should definitely make the #release method accepts arrays natively, so other storages could rely on this behavior and expect both string|integers or string|integer arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants