Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save notification option on localstorage #383

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

augustoscher
Copy link

@augustoscher augustoscher commented Jul 13, 2021

Description

In order to fix #332 we are persisting user enable/disable notification option on localstorage.

How to test?

  1. Run matrix on augusto/save-notification-option-localstorage branch.
  • Notifications should be disabled by default.
  • notification-disabled key shouldn't exists on localstorage.

image

  1. Enable notifications.
    Enable notifications by clicking on NotificationCheckbox component.
  • notification-disabled key should be created on localstorage with false value.

image

  • TOGGLE_NOTIFICATION should be dispatched and systemSettings.notificationDisabled property should be updated to false on redux store.
  • NotificationCheckbox component should let user disable notifications.
  1. Disable notifications
  • Users should be able to disable notifications again from another tab or inside a room

image

Expected behavior

Now matrix will save user notifications option. It will not being necessary enable and disable it every time that page is refreshed or application accessed.

@angeliski angeliski requested a review from megatroom July 14, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist desktop notifications on/off preference
1 participant