Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node selector to deployments #99

Open
atropos112 opened this issue May 2, 2023 · 3 comments
Open

Add node selector to deployments #99

atropos112 opened this issue May 2, 2023 · 3 comments

Comments

@atropos112
Copy link

Rocketchat (currently) does not support arm64. I am running nodes that are both arm64 and amd64 and currently can't select for rocketchat to only run on amd64 as such I sometimes see crashlooping because it tries to schedule on arm64 node.

Best and easiest solution here is to add nodeSelector to deployment templates. PR here: #98

@ChrisJBurns
Copy link

I don't mind closing mine: #97 ?

@TheBoboNL
Copy link

TheBoboNL commented Jul 3, 2023

you can use the affinity node to do this select, however than you run into the issue with upgrading that the hook-verify-mongodb-version.yaml does not support this affinity and can deploy a pod on a ARM node.

So that yaml will also need to be updated.

to use the affinity you get something like this:

affinity:
  nodeAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      nodeSelectorTerms:
      - matchExpressions:
        - key: kubernetes.io/arch
          operator: In
          values:
          - amd64

@ChrisJBurns
Copy link

@TheBoboNL its recommended to use nodeSelector as per https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants