Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rimd library is now fairly out of date with respect to modern Rust style -- let's fix that #16

Open
akesling opened this issue Dec 4, 2020 · 2 comments
Open

rimd library is now fairly out of date with respect to modern Rust style -- let's fix that #16

akesling opened this issue Dec 4, 2020 · 2 comments

Comments

@akesling
Copy link
Contributor

akesling commented Dec 4, 2020

Running cargo clippy provides the following output : https://gist.github.com/akesling/4535958548c362d09d52fa5c86c24f23

I propose fixing these issues.
This was referenced Dec 4, 2020
Closed
Merged
@Boscop
Copy link
Member

Boscop commented Dec 6, 2020

It also uses the old num-derive 0.2 which gives me an error when another dep depends on 0.3 :/

@akesling
Copy link
Contributor Author

akesling commented Dec 7, 2020

Great suggestion @Boscop. I've created a pull request for that update: #19

@akesling akesling mentioned this issue Dec 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akesling @Boscop