Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Infobar showing applied filters in platform table #11783

Open
do-oel opened this issue Apr 19, 2024 · 3 comments · Fixed by #12634 · May be fixed by #12864
Open

[Feature Request] Infobar showing applied filters in platform table #11783

do-oel opened this issue Apr 19, 2024 · 3 comments · Fixed by #12634 · May be fixed by #12864
Assignees

Comments

@do-oel
Copy link

do-oel commented Apr 19, 2024

Is this a bug, enhancement, or feature request?

Feature Request

Describe your proposal.

According to the Fiori Guidelines, filtered tables display an info bar (toolbar in active mode) below the table toolbar to indicate the set filter. "Beneath the toolbar, display a filter infobar (which itself is a special toolbar) if the responsive table is filtered." (https://experience.sap.com/fiori-design-web/responsive-table/#components)

The infobar should use the following component from Fundamental NGX: <fd-toolbar fdType="info" [active]="true"> with
Text: "Filtered By: Column Name (Filter Parameters)", e.g., "Filtered By: Size (XS, M, L)"
Icon: "decline"

The infobar should only appear once a filter is set and disappear once the filter is reset.

Example wire:
image

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

All, current version (v0.49), if possible downport to v0.48

If this is a bug, please provide steps for reproducing it; the exact components you are using;

N/A

Please provide relevant source code (if applicable).

N/A

Please provide stackblitz example(s).

N/A

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

N/A

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Yes

Is there anything else we should know?

N/A

@rebecagm
Copy link

Hi @droshev and @dpavlenishvili Could we prioritise this feature in the upcoming sprints? With our product release approaching, we want to ensure the table filters function correctly to enhance the user experience.

@droshev
Copy link
Contributor

droshev commented Sep 10, 2024

@rebecagm We are doing our best. We will keep you posted.

khotcholava added a commit that referenced this issue Oct 21, 2024
closes [#11783](#11783)

- Implemented an info bar beneath the table toolbar to display active filters, following SAP Fiori design recommendations.
- Used <fd-toolbar fdType="info" [active]="true"> from Fundamental NGX.
- Displayed filter information with the correct format
- Included a "decline" icon in the info bar.
- Info bar appears only when a filter is applied and hides once the filter is reset.
khotcholava added a commit that referenced this issue Oct 22, 2024
closes [#11783](#11783)

- Added feature to close the popover when the dismiss button is clicked. The popover will reappear upon changing the filters.
khotcholava added a commit that referenced this issue Oct 23, 2024
closes [#11783](#11783)

- Refactored/simplified css selector for pointer event
khotcholava added a commit that referenced this issue Oct 23, 2024
closes [#11783](#11783)

## Description

- Moved hardcoded "Filtered by" string into translation file
khotcholava added a commit that referenced this issue Oct 24, 2024
khotcholava added a commit that referenced this issue Oct 24, 2024
khotcholava added a commit that referenced this issue Oct 25, 2024
closes [#11783](#11783)

## Description
Added fcCompact to table toolbar fliter close button.
khotcholava added a commit that referenced this issue Oct 29, 2024
closes [#11783](#11783)

## Description
 Update _setAppliedFilterNames function to properly format nested parameters
khotcholava added a commit that referenced this issue Oct 29, 2024
closes [#11783](#11783)

- Added reset filter functionality on close toolbar click
- Removed logs
- Clean up the code
droshev pushed a commit that referenced this issue Nov 6, 2024
)

* fix(platform): table showing info bar with selected filters

closes [#11783](#11783)

- Implemented an info bar beneath the table toolbar to display active filters, following SAP Fiori design recommendations.
- Used <fd-toolbar fdType="info" [active]="true"> from Fundamental NGX.
- Displayed filter information with the correct format
- Included a "decline" icon in the info bar.
- Info bar appears only when a filter is applied and hides once the filter is reset.

* fix(platform): Update info bar table to reflect selected filters

closes [#11783](#11783)

- Added feature to close the popover when the dismiss button is clicked. The popover will reappear upon changing the filters.

* fix(platform): table showing info bar with selected filters

closes [#11783](#11783)

## Description

- Moved hardcoded "Filtered by" string into translation file

* fix(platform): table showing info bar with selected filters

closes [#11783](#11783)

- Minor refactor

* fix(platform): table showing info bar with selected filters

closes [#11783](#11783)

## Description

- Fiex build

* fix(platform): table showing info bar with selected filters

closes [#11783](#11783)

## Description
Added fcCompact to table toolbar fliter close button.

* fix(platform): table showing info bar with selected filters

closes [#11783](#11783)

## Description
 Update _setAppliedFilterNames function to properly format nested parameters

* fix(platform): table showing info bar with selected filters

closes [#11783](#11783)

- Added reset filter functionality on close toolbar click
- Removed logs
- Clean up the code
@droshev droshev reopened this Nov 15, 2024
@droshev
Copy link
Contributor

droshev commented Nov 15, 2024

@khotcholava there are 2 issues reported in the PR:
Thanks for this fix! Highly appreciated.

Two smaller things for improvement:

  1. The filter info bar shows an index number in front of the filter term. This should be hidden (e.g, Filtered by: StatusColor (0: positive)
  2. The category name is using no spaces, this seems a bit weird (e.g, StatusColor instead of Status Color)
image

Can you take a look?

khotcholava added a commit that referenced this issue Nov 19, 2024
closes [#11783](#11783)

- add support for formatting array values in table component
mikerodonnell89 added a commit that referenced this issue Nov 22, 2024
* fix(core): Checkbox link in  label  is not clickable

closes [#12577](#12577)

## Description
Updated the checkbox component to ensure that links within custom labels are clickable and function as intended. This resolves the issue observed in the documentation example.

* fix(platform): table showing info bar with selected filters

closes [#11783](#11783)

- Refactored/simplified css selector for pointer event

* fix(core): do not pointer-events: auto for disabled checkboxes

* fix: e2e

---------

Co-authored-by: Mike O'Donnell <[email protected]>
Co-authored-by: deno <[email protected]>
Co-authored-by: [email protected] <[email protected]>
khotcholava added a commit that referenced this issue Nov 25, 2024
closes [#11783](#11783)

## Description

Updated the filter parameter to use the column name for improved representation.
khotcholava added a commit that referenced this issue Nov 29, 2024
closes [#11783](#11783)

## Description

fix table component host spec test
khotcholava added a commit that referenced this issue Nov 29, 2024
closes [#11783](#11783)

## Description

fix table component host spec test
khotcholava added a commit that referenced this issue Nov 29, 2024
closes [#11783](#11783)

## Description

fix table component host spec test
khotcholava added a commit that referenced this issue Nov 29, 2024
closes [#11783](#11783)

## Description

fix table component host spec test
khotcholava added a commit that referenced this issue Dec 9, 2024
closes [#11783](#11783)

Correct handling of filter inputs by using the columnName instead of columnKey to better represent user selections. Additionally, toolbar styling is modified to prevent unnecessary shrinking, thus enhancing the overall interface consistency.
khotcholava added a commit that referenced this issue Dec 11, 2024
closes [#11783](#11783)

Fixed filter dialog filtering
khotcholava added a commit that referenced this issue Dec 11, 2024
closes [#11783](#11783)

Removed space between filter param and coma
khotcholava added a commit that referenced this issue Dec 11, 2024
khotcholava added a commit that referenced this issue Dec 17, 2024
khotcholava added a commit that referenced this issue Dec 19, 2024
closes [#11783](#11783)

Removed space between filter param and coma
khotcholava added a commit that referenced this issue Dec 19, 2024
khotcholava added a commit that referenced this issue Dec 19, 2024
khotcholava added a commit that referenced this issue Dec 20, 2024
closes [#11783](#11783)

- Add support for formatting array values in table component
- Fix format field name

## Before

<img width="666" alt="Screenshot 2024-11-25 at 17 49 05" src="https://github.com/user-attachments/assets/dd9fe3fd-2e4f-4c03-b4fd-462d0a9b8429">

## After

<img width="854" alt="Screenshot 2024-11-25 at 17 49 53" src="https://github.com/user-attachments/assets/c76fcdd5-44f6-4b59-b3ac-7576f43f1989">
@khotcholava khotcholava linked a pull request Dec 20, 2024 that will close this issue
khotcholava added a commit that referenced this issue Dec 20, 2024
closes [#11783](#11783)

- Fixed formatting

## Before

<img width="666" alt="Screenshot 2024-11-25 at 17 49 05" src="https://github.com/user-attachments/assets/dd9fe3fd-2e4f-4c03-b4fd-462d0a9b8429">

## After

<img width="854" alt="Screenshot 2024-11-25 at 17 49 53" src="https://github.com/user-attachments/assets/c76fcdd5-44f6-4b59-b3ac-7576f43f1989">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment