-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Infobar showing applied filters in platform table #11783
Comments
Hi @droshev and @dpavlenishvili Could we prioritise this feature in the upcoming sprints? With our product release approaching, we want to ensure the table filters function correctly to enhance the user experience. |
@rebecagm We are doing our best. We will keep you posted. |
closes [#11783](#11783) - Implemented an info bar beneath the table toolbar to display active filters, following SAP Fiori design recommendations. - Used <fd-toolbar fdType="info" [active]="true"> from Fundamental NGX. - Displayed filter information with the correct format - Included a "decline" icon in the info bar. - Info bar appears only when a filter is applied and hides once the filter is reset.
) * fix(platform): table showing info bar with selected filters closes [#11783](#11783) - Implemented an info bar beneath the table toolbar to display active filters, following SAP Fiori design recommendations. - Used <fd-toolbar fdType="info" [active]="true"> from Fundamental NGX. - Displayed filter information with the correct format - Included a "decline" icon in the info bar. - Info bar appears only when a filter is applied and hides once the filter is reset. * fix(platform): Update info bar table to reflect selected filters closes [#11783](#11783) - Added feature to close the popover when the dismiss button is clicked. The popover will reappear upon changing the filters. * fix(platform): table showing info bar with selected filters closes [#11783](#11783) ## Description - Moved hardcoded "Filtered by" string into translation file * fix(platform): table showing info bar with selected filters closes [#11783](#11783) - Minor refactor * fix(platform): table showing info bar with selected filters closes [#11783](#11783) ## Description - Fiex build * fix(platform): table showing info bar with selected filters closes [#11783](#11783) ## Description Added fcCompact to table toolbar fliter close button. * fix(platform): table showing info bar with selected filters closes [#11783](#11783) ## Description Update _setAppliedFilterNames function to properly format nested parameters * fix(platform): table showing info bar with selected filters closes [#11783](#11783) - Added reset filter functionality on close toolbar click - Removed logs - Clean up the code
@khotcholava there are 2 issues reported in the PR: Two smaller things for improvement:
Can you take a look? |
* fix(core): Checkbox link in label is not clickable closes [#12577](#12577) ## Description Updated the checkbox component to ensure that links within custom labels are clickable and function as intended. This resolves the issue observed in the documentation example. * fix(platform): table showing info bar with selected filters closes [#11783](#11783) - Refactored/simplified css selector for pointer event * fix(core): do not pointer-events: auto for disabled checkboxes * fix: e2e --------- Co-authored-by: Mike O'Donnell <[email protected]> Co-authored-by: deno <[email protected]> Co-authored-by: [email protected] <[email protected]>
closes [#11783](#11783) - Add support for formatting array values in table component - Fix format field name ## Before <img width="666" alt="Screenshot 2024-11-25 at 17 49 05" src="https://github.com/user-attachments/assets/dd9fe3fd-2e4f-4c03-b4fd-462d0a9b8429"> ## After <img width="854" alt="Screenshot 2024-11-25 at 17 49 53" src="https://github.com/user-attachments/assets/c76fcdd5-44f6-4b59-b3ac-7576f43f1989">
closes [#11783](#11783) - Fixed formatting ## Before <img width="666" alt="Screenshot 2024-11-25 at 17 49 05" src="https://github.com/user-attachments/assets/dd9fe3fd-2e4f-4c03-b4fd-462d0a9b8429"> ## After <img width="854" alt="Screenshot 2024-11-25 at 17 49 53" src="https://github.com/user-attachments/assets/c76fcdd5-44f6-4b59-b3ac-7576f43f1989">
Is this a bug, enhancement, or feature request?
Feature Request
Describe your proposal.
According to the Fiori Guidelines, filtered tables display an info bar (toolbar in active mode) below the table toolbar to indicate the set filter. "Beneath the toolbar, display a filter infobar (which itself is a special toolbar) if the responsive table is filtered." (https://experience.sap.com/fiori-design-web/responsive-table/#components)
The infobar should use the following component from Fundamental NGX: <fd-toolbar fdType="info" [active]="true"> with
Text: "Filtered By: Column Name (Filter Parameters)", e.g., "Filtered By: Size (XS, M, L)"
Icon: "decline"
The infobar should only appear once a filter is set and disappear once the filter is reset.
Example wire:
Can you handle that on the application side
No
Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)
All, current version (v0.49), if possible downport to v0.48
If this is a bug, please provide steps for reproducing it; the exact components you are using;
N/A
Please provide relevant source code (if applicable).
N/A
Please provide stackblitz example(s).
N/A
In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.
N/A
Did you check the documentation and the API?
Yes
Did you search for similar issues?
Yes
Is there anything else we should know?
N/A
The text was updated successfully, but these errors were encountered: