Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code completion for SAP-icons #509

Open
uxkjaer opened this issue Oct 19, 2022 · 3 comments · May be fixed by #512
Open

Code completion for SAP-icons #509

uxkjaer opened this issue Oct 19, 2022 · 3 comments · May be fixed by #512
Labels
enhancement New feature or request

Comments

@uxkjaer
Copy link
Member

uxkjaer commented Oct 19, 2022

A handy feature would be code completion for SAP-icons with a preview. Similar to this extension
@uxkjaer uxkjaer added the enhancement New feature or request label Oct 19, 2022
@uxkjaer
Copy link
Member Author

uxkjaer commented Oct 19, 2022 •
edited
Loading

URL for getting icon font names are
https://sapui5.hana.ondemand.com/sdk/test-resources/sap/m/demokit/iconExplorer/webapp/model/SAP-icons/tags.json
https://sapui5.hana.ondemand.com/sdk/test-resources/sap/m/demokit/iconExplorer/webapp/model/SAP-icons-TNT/tags.json
https://sapui5.hana.ondemand.com/sdk/test-resources/sap/m/demokit/iconExplorer/webapp/model/BusinessSuiteInAppSymbols/tags.json

@uxkjaer
Copy link
Member Author

uxkjaer commented Oct 21, 2022

This shows a POC i created.
image

@uxkjaer
Copy link
Member Author

uxkjaer commented Oct 21, 2022

This array contains the reference between name and 16 bit code that can be adapted to the icon format via

// helper functions
		function makeChar(code) {
			return String.fromCharCode(typeof code === 'number' ? code : parseInt(code, 16));
		}

@uxkjaer uxkjaer linked a pull request Oct 21, 2022 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: SAP icons in editor or hover SAP/ui5-language-assistant
1 participant
@uxkjaer